[v14.x backport] errors: do not call resolve on URLs with schemes #37717
Conversation
bcoe
changed the title
We were incorrectly trying to run path.resolve on absolute sources URLs. This was breaking webpack:// URLs in stack trace output. Refs: nodejs#35325 Backport-PR-URL: nodejs#37717 PR-URL: nodejs#35903 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bcoe
force-pushed
the
backport-webpack-fix
branch
from
8cae83d
to
1cde0f9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bcoe
force-pushed
the
backport-webpack-fix
branch
from
35bd63e
to
1cde0f9
Compare
bcoe
force-pushed
the
backport-webpack-fix
branch
from
1cde0f9
to
2197404
Compare
We were incorrectly trying to run path.resolve on absolute sources URLs. This was breaking webpack:// URLs in stack trace output. Refs: nodejs#35325 Backport-PR-URL: nodejs#37717 PR-URL: nodejs#35903 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bcoe
force-pushed
the
backport-webpack-fix
branch
from
2197404
to
f91f140
Compare
|
@aduh95 any idea where to go next with the |
Sorry I can't explain the failure either, it's really weird. |
|
@bcoe is this same target failing the same way if you try running them in |
|
@ruyadorno v14.x-staging seems fine, so something about this PR is breaking the test. The weird thing is the test isn't failing on test-asan on the main branch either (which includes this change). We might need to try to reproduce in a container locally. |
bcoe
force-pushed
the
backport-webpack-fix
branch
2 times, most recently
from
5c95073
to
0e1a9b5
Compare
We were incorrectly trying to run path.resolve on absolute sources URLs. This was breaking webpack:// URLs in stack trace output. Refs: nodejs#35325 Backport-PR-URL: nodejs#37717 PR-URL: nodejs#35903 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bcoe
force-pushed
the
backport-webpack-fix
branch
from
e59434d
to
e4ad78b
Compare
|
@targos @richardlau I've been unable to reproduce the I noticed in #38001 we also landed a PR to 14.x-staging with test-asan failures, is it alright if I do likewise with this PR? (perhaps with a tracking issue to dig into |
MylesBorins
force-pushed
the
v14.x-staging
branch
from
11505ad
to
6b115d7
Compare
We were incorrectly trying to run path.resolve on absolute sources URLs. This was breaking webpack:// URLs in stack trace output. Refs: nodejs#35325 PR-URL: nodejs#35903 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
force-pushed
the
backport-webpack-fix
branch
from
e4ad78b
to
753d783
Compare
We were incorrectly trying to run path.resolve on absolute sources URLs. This was breaking webpack:// URLs in stack trace output. Refs: #35325 PR-URL: #35903 Backport-PR-URL: #37717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed in b01c496 |
We were incorrectly trying to run path.resolve on absolute
sources URLs. This was breaking webpack:// URLs in stack
trace output.
Refs: #35325
PR-URL: #35903
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com