Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move Derek Lewis back to collaborators #37726

Merged
merged 1 commit into from Mar 20, 2021
Merged

doc: move Derek Lewis back to collaborators #37726

merged 1 commit into from Mar 20, 2021

Conversation

DerekNonGeneric
Copy link
Contributor

Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514


The astronomical start of spring this year is Saturday, March 20, 2021.

Goals for the season include a more sophisticated and polished hook system (pending results of the discussion topic lead by @GeoffreyBooth) for custom loader use (as well as addressing the outstanding bugs in https://github.com/nodejs/modules).

/cc @Trott to check

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 12, 2021
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back!

Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally LGTM.

As far as I understand our process is that this is brought up to the next TSC meeting :

The TSC can remove inactive Collaborators or provide them with Emeritus status. Emeriti may request that the TSC restore them to active status.

rather than as a pull request.

@benjamingr
Copy link
Member

And welcome back <3 :)

@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Mar 12, 2021
@Trott
Copy link
Member

Trott commented Mar 12, 2021

I added the blocked label to make sure this doesn't land before TSC review. Adding the tsc-agenda label too although we may take it up in email before the next meeting rather than waiting until then.

@Trott Trott added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Mar 12, 2021
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back, and thank you! We could really use your help 😄

@DerekNonGeneric
Copy link
Contributor Author

DerekNonGeneric commented Mar 17, 2021

I have converted this to a draft to ensure accuracy in timing (my exact availability may be changing) and depending on the results of the meeting.

@Trott Trott removed the blocked PRs that are blocked by other issues or PRs. label Mar 17, 2021
@DerekNonGeneric DerekNonGeneric marked this pull request as ready for review March 20, 2021 00:24
@DerekNonGeneric
Copy link
Contributor Author

DerekNonGeneric commented Mar 20, 2021

The meeting results appeared positive, so I will keep this open and landable for when I return next month.

Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514

PR-URL: #37726
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott
Copy link
Member

Trott commented Mar 20, 2021

Landed in e427c48

@Trott Trott merged commit e427c48 into nodejs:master Mar 20, 2021
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514

PR-URL: #37726
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514

PR-URL: #37726
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet