tools: simplify eslint comma-dangle configuration #37850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
benchmark
targos
approved these changes
Mar 21, 2021
marsonya
approved these changes
Mar 21, 2021
benjamingr
approved these changes
Mar 21, 2021
jasnell
approved these changes
Mar 22, 2021
jasnell
added
the
author ready
Remove comma-dangle settings in benchmark/.eslintrc.yaml as they are the same as what is set in .eslintrc.js. PR-URL: nodejs#37850 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 448158e |
ruyadorno
pushed a commit
that referenced
this pull request
Mar 29, 2021
Remove comma-dangle settings in benchmark/.eslintrc.yaml as they are the same as what is set in .eslintrc.js. PR-URL: #37850 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 30, 2021
Remove comma-dangle settings in benchmark/.eslintrc.yaml as they are the same as what is set in .eslintrc.js. PR-URL: #37850 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Remove comma-dangle settings in benchmark/.eslintrc.yaml as they are the same as what is set in .eslintrc.js. PR-URL: #37850 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Remove comma-dangle settings in benchmark/.eslintrc.yaml as they are the same as what is set in .eslintrc.js. PR-URL: #37850 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Remove comma-dangle settings in benchmark/.eslintrc.yaml as they are the same as what is set in .eslintrc.js. PR-URL: #37850 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove comma-dangle settings in benchmark/.eslintrc.yaml as they are the
same as what is set in .eslintrc.js.