Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,intl: spell out ICU acronym on first occurrence #37942

Merged
merged 1 commit into from Mar 27, 2021
Merged

doc,intl: spell out ICU acronym on first occurrence #37942

merged 1 commit into from Mar 27, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 27, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 27, 2021
@Trott Trott changed the title doc,intl: speall out ICU acronym on first occurrence doc,intl: spell out ICU acronym on first occurrence Mar 27, 2021
jasnell
jasnell approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast track? There's no reason to make this one wait

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 27, 2021
@Trott
doc: spell out ICU acronym on first occurrence
b560645 
PR-URL: nodejs#37942
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott merged commit b560645 into nodejs:master Mar 27, 2021
@Trott
Copy link
Member Author

Trott commented Mar 27, 2021

Landed in b560645

@Trott Trott deleted the icu-meaning branch March 27, 2021 20:35
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
@Trott @ruyadorno
doc: spell out ICU acronym on first occurrence
0c200f8 
PR-URL: #37942
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
@Trott @ruyadorno
doc: spell out ICU acronym on first occurrence
0fe3c7e 
PR-URL: #37942
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: spell out ICU acronym on first occurrence
dd1c47b 
PR-URL: #37942
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Trott @jasnell @lpinca @targos @cjihrig @aduh95 @RaisinTen @nodejs-github-bot