[v15.x] deps: V8 cycle fix & parent ordering backports #37985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[top-level-await] Implement spec fix for cycle root detection Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 PR-URL: nodejs#37865 Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot
added
build
This comment has been minimized.
This comment has been minimized.
guybedford
force-pushed
the
v8-cycle-fix-backport-15
branch
from
b2fb40e
to
e3e5b8b
Compare
This comment has been minimized.
This comment has been minimized.
guybedford
force-pushed
the
v8-cycle-fix-backport-15
branch
from
e3e5b8b
to
1d53fe7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: nodejs#37864 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guybedford
force-pushed
the
v8-cycle-fix-backport-15
branch
from
1d53fe7
to
d68be4a
Compare
This comment has been minimized.
This comment has been minimized.
ruyadorno
approved these changes
Mar 31, 2021
ruyadorno
pushed a commit
that referenced
this pull request
Mar 31, 2021
[top-level-await] Implement spec fix for cycle root detection Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 PR-URL: #37865 Backport-PR-URL: #37985 Reviewed-By: Michaël Zasso <targos@protonmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 31, 2021
[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: #37864 Backport-PR-URL: #37985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports both #37865 and 8e46568 for v15.x.
//cc @ruyadorno