Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: remove redundant method for connection check #37986

Closed
wants to merge 1 commit into from
Closed

inspector: remove redundant method for connection check #37986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/inspector_agent.cc
View file
Open in desktop
Expand Up @@ -898,13 +898,6 @@ void Agent::ContextCreated(Local<Context> context, const ContextInfo& info) {
client_->contextCreated(context, info);
}

bool Agent::WillWaitForConnect() {
if (debug_options_.wait_for_connect()) return true;
if (parent_handle_)
return parent_handle_->WaitForConnect();
return false;
}

bool Agent::IsActive() {
if (client_ == nullptr)
return false;
Expand Down
2 changes: 0 additions & 2 deletions src/inspector_agent.h
View file
Open in desktop
Expand Up @@ -59,8 +59,6 @@ class Agent {
// --inspect command line flag) or if inspector JS API had been used.
bool IsActive();

// Option is set to wait for session connection
bool WillWaitForConnect();
// Blocks till frontend connects and sends "runIfWaitingForDebugger"
void WaitForConnect();
// Blocks till all the sessions with "WaitForDisconnectOnShutdown" disconnect
Expand Down