Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: make reference weak parameter an indirect link to references #38000

Closed
wants to merge 3 commits into from
Closed

node-api: make reference weak parameter an indirect link to references #38000

wants to merge 3 commits into from

Commits on Mar 31, 2021

  1. node-api: make reference weak parameter an indirect link to references 

    As the cancellation of second pass callbacks are not reachable from the current
v8 API, and the second pass callbacks are scheduled with NodePlatform's task
runner, we have to ensure that the weak parameter holds indirect access to the
v8impl::Reference object so that the object can be destroyed on addon env
teardown before the whole node env is able to shutdown.
    @legendecas
    legendecas committed Mar 31, 2021
    Copy the full SHA
    48c95d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. squash: update wording, tweak comments

    @mhdawson
    mhdawson committed Apr 7, 2021
    Copy the full SHA
    a85e1f7 View commit details
    Browse the repository at this point in the history

  2. squash: fixup 

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed Apr 7, 2021
    Copy the full SHA
    98eecdf View commit details
    Browse the repository at this point in the history