build: package release changelog for releases #38033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package the changelog for the release line as `CHANGELOG.md` when building a release binary tarball.
nodejs-github-bot
added
build
juanarbol
approved these changes
Apr 3, 2021
Trott
approved these changes
Apr 3, 2021
targos
approved these changes
Apr 4, 2021
BethGriggs
approved these changes
Apr 6, 2021
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Apr 6, 2021
aduh95
added
the
author ready
This comment has been minimized.
This comment has been minimized.
|
Landed in 9cfb418 |
jasnell
pushed a commit
that referenced
this pull request
Apr 7, 2021
Package the changelog for the release line as `CHANGELOG.md` when building a release binary tarball. PR-URL: #38033 Fixes: #38025 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Package the changelog for the release line as `CHANGELOG.md` when building a release binary tarball. PR-URL: #38033 Fixes: #38025 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package the changelog for the release line as
CHANGELOG.mdwhenbuilding a release binary tarball.
Fixes: #38025
cc @nodejs/releasers