Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: sending http request to localhost to avoid https redirect #38036

Closed
wants to merge 3 commits into from
Closed

doc: sending http request to localhost to avoid https redirect #38036

wants to merge 3 commits into from

Commits on Apr 2, 2021

  1. doc: sending http request to localhost to avoid https redirect 

    In the JSON fetching example, http.get request is being sent to an http url that redirects to https. This causes the http.get request to fail. To avoid redirect errors, a local http server is set up that returns a json response.

Fixes: nodejs#37907
    @hassaanp
    hassaanp committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    2da6327 View commit details
    Browse the repository at this point in the history

  2. Update doc/api/http.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @hassaanp @aduh95
    hassaanp and aduh95 committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    3b346d4 View commit details
    Browse the repository at this point in the history

  3. Update doc/api/http.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @hassaanp @aduh95
    hassaanp and aduh95 committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    3b2f38c View commit details
    Browse the repository at this point in the history