Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.14.0 proposal #38084

Merged
merged 41 commits into from Apr 6, 2021
Merged

v15.14.0 proposal #38084

merged 41 commits into from Apr 6, 2021

Commits on Apr 4, 2021

  1. deps: cjs-module-lexer: cherry-pick 22093e765f

    Original commit message:
    	fix "the the" typo in README.md file
    
    Refs: nodejs/cjs-module-lexer@22093e7
    
    PR-URL: #37895
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    peZhmanParsaee authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    913ec56 View commit details
    Browse the repository at this point in the history
  2. test: add DataView test case for v8 serdes

    This completes code coverage for v8.js.
    
    Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/v8.js.html#L240
    
    PR-URL: #37955
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    5e15ae0 View commit details
    Browse the repository at this point in the history
  3. url: forbid pipe in URL host

    Fixes: #37862
    
    PR-URL: #37877
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RaisinTen authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    570fbce View commit details
    Browse the repository at this point in the history
  4. doc: add Windows-specific info to subprocess.kill()

    Clarify the inner workings of .kill on Windows,
    since termination signals are not available there.
    
    Fixes: #34858
    
    PR-URL: #34867
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    joaolucasl authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    13c3924 View commit details
    Browse the repository at this point in the history
  5. deps: upgrade openssl sources to 1.1.1k+quic

    This updates all sources in deps/openssl/openssl by:
        $ git clone https://github.com/quictls/openssl
        $ cd openssl
        $ git checkout OpenSSL_1_1_1k+quic
        $ cd ../node/deps/openssl
        $ rm -rf openssl
        $ cp -R ../openssl openssl
        $ cd openssl && rm -rf .gitattributes .github/ .gitmodules .travis-apt-pin.preferences  .travis-create-release.sh
        $ cd ..
        $ git add --all openssl
        $ git commit openssl
    
    PR-URL: #37916
    Fixes: #37913
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    hassaanp authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    bbdcdad View commit details
    Browse the repository at this point in the history
  6. deps: update archs files for OpenSSL-1.1.1k

     After an OpenSSL source update, all the config files need to be
     regenerated and committed by:
        $ make -C deps/openssl/config
        $ git add deps/openssl/config/archs
        $ git add deps/openssl/openssl/include/crypto/bn_conf.h
        $ git add deps/openssl/openssl/include/crypto/dso_conf.h
        $ git add deps/openssl/openssl/include/openssl/opensslconf.h
        $ git commit
    
    PR-URL: #37916
    Fixes: #37913
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    hassaanp authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    f0e7714 View commit details
    Browse the repository at this point in the history
  7. doc: add missing cleanup step in OpenSSL upgrade

    Refs: #37916
    
    PR-URL: #37927
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    tniessen authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    f3fabb5 View commit details
    Browse the repository at this point in the history
  8. doc: improve Buffer's encoding documentation

    - Add a paragraph about case-insensitivity of encoding options.
    - Document "utf-8", "utf-16le" and "ucs-2" aliases.
    - Always use "utf8" in documentation for defaults and examples.
    
    PR-URL: #37945
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    a57dc06 View commit details
    Browse the repository at this point in the history
  9. http: optimize debug function correctly

    Exporting a variable that will be mutated later doesn't work.
    
    Refs: #37937
    
    PR-URL: #37966
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    d86aca9 View commit details
    Browse the repository at this point in the history
  10. path: refactor to use more primordials

    PR-URL: #37893
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    marsonya authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    a94cc27 View commit details
    Browse the repository at this point in the history
  11. deps: update to cjs-module-lexer@1.1.1

    PR-URL: #37992
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    guybedford authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    4ef102d View commit details
    Browse the repository at this point in the history
  12. tools,doc: add "legacy" badge in the TOC

    PR-URL: #37949
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    51e7a33 View commit details
    Browse the repository at this point in the history
  13. http2: add specific error code for custom frames

    As suggested in
    #37849 (comment)
    improve the error presented when encountering a large number of
    invalid frames by giving this situation a specific error code (which we
    should have had from the beginning).
    
    PR-URL: #37936
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    addaleax authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    062541a View commit details
    Browse the repository at this point in the history
  14. doc: add missing events.on metadata

    This was missed in the original PR.
    
    Refs: #34912
    
    PR-URL: #37965
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    8792c7c View commit details
    Browse the repository at this point in the history
  15. net,tls: add abort signal support to connect

    Add documentation for net.connect AbortSignal,
    and add the support to tls.connect as well
    
    PR-URL: #37735
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Linkgoron authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    669b81c View commit details
    Browse the repository at this point in the history
  16. readline: add AbortSignal support to interface

    Add abort signal support to Interface
    
    PR-URL: #37932
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Linkgoron authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    a1123f0 View commit details
    Browse the repository at this point in the history
  17. readline: fix pre-aborted signal question handling

    fix pre-aborted question handling
    
    PR-URL: #37929
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Linkgoron authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    6cc1e15 View commit details
    Browse the repository at this point in the history
  18. lib: change wording in lib/internal/child_process comment

    Change the wording to make the language more Inclusive.
    
    PR-URL: #37903
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    marsonya authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    21e399b View commit details
    Browse the repository at this point in the history
  19. lib: change wording in lib/domain.js comment

    Change the wording to make the language more Inclusive.
    
    PR-URL: #37933
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    marsonya authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    8525231 View commit details
    Browse the repository at this point in the history
  20. doc: add distinctive color for code elements inside links

    PR-URL: #37950
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    ae70aa3 View commit details
    Browse the repository at this point in the history
  21. net: make net.BlockList cloneable

    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #37917
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    jasnell authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    a4169ce View commit details
    Browse the repository at this point in the history
  22. net: add SocketAddress class

    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #37917
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    jasnell authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    daa8a7b View commit details
    Browse the repository at this point in the history
  23. net: allow net.BlockList to use net.SocketAddress objects

    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #37917
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    jasnell authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    0709cbb View commit details
    Browse the repository at this point in the history
  24. test: improve clarity of ALS-enable-disable.js

    The last als.run() will reactivate the als,
    hence the test should test for getting the object,
    not undefined
    
    PR-URL: #38008
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PhakornKiong authored and MylesBorins committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    4d50975 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. doc: move psmarshall to collaborators emeriti

    PR-URL: #37994
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    psmarshall authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    ce14080 View commit details
    Browse the repository at this point in the history
  2. fs: fix chown abort

    This syncs the type assertion introduced in the referenced PR in the C++
    side. Since chown, lchown, and fchown can accept -1 as a value for uid
    and gid, we should also accept signed integers from the JS side.
    
    Fixes: #37995
    Refs: #31694
    
    PR-URL: #38004
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RaisinTen authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    ad7e344 View commit details
    Browse the repository at this point in the history
  3. src: fix error handling for CryptoJob::ToResult

    PR-URL: #37076
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6ad0b6f View commit details
    Browse the repository at this point in the history
  4. tools: update ESLint to 7.23.0

    PR-URL: #37979
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6d28a24 View commit details
    Browse the repository at this point in the history
  5. test: deflake test-fs-read-optional-params

    If `fs.read()` is called without specifying the `position` option, data
    will be read from the current file position. There is another concurrent
    `fs.read()` call before the test for no options object which might
    invalidate the test expectations.
    
    Run the test for no options object first.
    
    PR-URL: #37991
    Fixes: #37946
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    lpinca authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    0db1a1e View commit details
    Browse the repository at this point in the history
  6. crypto: add buffering to randomInt

    PR-URL: #35110
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    tniessen authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    960c6be View commit details
    Browse the repository at this point in the history
  7. test: fix test-tls-no-sslv3 for OpenSSL 3

    OpenSSL 3 has changed the format of the error message for an unknown
    option to the CLI. Update the test to allow for the older and newer
    message formats.
    
    PR-URL: #38027
    Refs: openssl/openssl#10774
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    richardlau authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    b02c352 View commit details
    Browse the repository at this point in the history
  8. doc: document how to unref stdin when using readline.Interface

    PR-URL: #38019
    Fixes: #36154
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    AnupamaP authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    b40d35d View commit details
    Browse the repository at this point in the history
  9. test: use faster variant for rss

    PR-URL: #36839
    Refs: #34291
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PoojaDurgad authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    0243376 View commit details
    Browse the repository at this point in the history
  10. module: improve error message for invalid data URL

    Fixes: #37647
    
    PR-URL: #37701
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    aduh95 authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    3ab9619 View commit details
    Browse the repository at this point in the history
  11. test: add extra space in test failure output

    PR-URL: #37957
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Ayase-252 authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    3175559 View commit details
    Browse the repository at this point in the history
  12. doc: fix asyncLocalStorage.run() description

    The description that store is not available
    when asynchronous operation is created within
    the callback is not accurate
    
    Fixes: #38022
    
    PR-URL: #38023
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    PhakornKiong authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    afc6ab2 View commit details
    Browse the repository at this point in the history
  13. crypto: use correct webcrypto RSASSA-PKCS1-v1_5 algorithm name

    PR-URL: #38029
    Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    ac69b95 View commit details
    Browse the repository at this point in the history
  14. src: fix typos in crypto comments

    PR-URL: #38024
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    tniessen authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    e61cc0b View commit details
    Browse the repository at this point in the history
  15. fs: add support for async iterators to fsPromises.writeFile

    Fixes: #37391
    
    PR-URL: #37490
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    HiroyukiYagihashi authored and MylesBorins committed Apr 5, 2021
    4 Configuration menu
    Copy the full SHA
    b6f4901 View commit details
    Browse the repository at this point in the history
  16. src: fix typo in node_mutex

    PR-URL: #38011
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and MylesBorins committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    629e72e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. 2021-04-06, Version 15.14.0 (Current)

    Notable Changes:
    
    This is a security release.
    
    Vulnerabilities fixed:
    
    - **CVE-2021-3450**: OpenSSL - CA certificate check bypass with X509_V_FLAG_X509_STRICT (High)
    - **CVE-2021-3449**: OpenSSL - NULL pointer deref in signature_algorithms processing (High)
    - **CVE-2020-7774**: npm upgrade - Update y18n to fix Prototype-Pollution (High)
    
    Other Notable changes:
    
    fs:
      * (SEMVER-MINOR) add support for async iterators to `fsPromises.writeFile` (HiroyukiYagihashi) #37490
    net:
      * (SEMVER-MINOR) allow net.BlockList to use net.SocketAddress objects (James M Snell) #37917
      * (SEMVER-MINOR) add SocketAddress class (James M Snell) #37917
      * (SEMVER-MINOR) make net.BlockList cloneable (James M Snell) #37917
    net,tls:
      * (SEMVER-MINOR) add abort signal support to connect (Nitzan Uziely) #37735
    readline:
      * (SEMVER-MINOR) add AbortSignal support to interface (Nitzan Uziely) #37932
    
    PR-URL: #38084
    MylesBorins committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    1a34e9c View commit details
    Browse the repository at this point in the history