Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: improve compare.R output #38118

Closed
wants to merge 1 commit into from
Closed

benchmark: improve compare.R output #38118

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Apr 6, 2021 •
edited

Before:

events/ee-emit.jslisteners=1 argc=0 n=10                -2.31 %       ±3.60% ±4.79% ±6.24%

After:

events/ee-emit.js listeners=1 argc=0 n=10                -2.31 %       ±3.60% ±4.79% ±6.24%

FWIW I'm not an R expert, but this seemed like the correct solution.

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Apr 6, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37355/

@jasnell
Copy link
Member

jasnell commented Apr 12, 2021

Landed in 0180fc5

@jasnell jasnell closed this Apr 12, 2021
jasnell pushed a commit that referenced this pull request Apr 12, 2021
@mscdex @jasnell
benchmark: improve compare.R output
0180fc5 
PR-URL: #38118
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@mscdex @BethGriggs
benchmark: improve compare.R output
ceb049e 
PR-URL: #38118
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@mscdex @targos
benchmark: improve compare.R output
c00c31c 
PR-URL: #38118
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@mscdex @danielleadams
benchmark: improve compare.R output
668c210 
PR-URL: #38118
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@mscdex mscdex deleted the benchmark-improve-compare-output branch May 24, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mscdex @nodejs-github-bot @jasnell @Trott @cjihrig @RaisinTen