Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 501482cbc704 #38121

Merged
merged 2 commits into from Apr 9, 2021
Merged

deps: V8: cherry-pick 501482cbc704 #38121

merged 2 commits into from Apr 9, 2021

Commits on Apr 9, 2021

  1. deps: V8: cherry-pick 501482cbc704

    Original commit message:
    
        Fix ValueDeserializer::ReadDouble() bounds check
    
        If end_ is smaller than sizeof(double), the result would wrap
        around, and lead to an invalid memory access.
    
        Refs: nodejs#37978
        Change-Id: Ibc8ddcb0c090358789a6a02f550538f91d431c1d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2801353
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Commit-Queue: Marja Hölttä <marja@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#73800}
    
    PR-URL: nodejs#38121
    Fixes: nodejs#37978
    Refs: v8/v8@501482cbc704
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    cjihrig committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    ca13f7a View commit details
    Browse the repository at this point in the history
  2. test: add regression test for serdes readDouble()

    Refs: nodejs#37978
    PR-URL: nodejs#38121
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    cjihrig committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    e96773b View commit details
    Browse the repository at this point in the history