Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update links in ICU guide #38177

Closed
wants to merge 1 commit into from
Closed

doc: update links in ICU guide #38177

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 9, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 9, 2021
targos added a commit that referenced this pull request Apr 12, 2021
@targos
doc: update links in ICU guide
5823fc7 
PR-URL: #38177
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos
Copy link
Member Author

targos commented Apr 12, 2021

Landed in 5823fc7

@targos targos closed this Apr 12, 2021
@targos targos deleted the icu-links branch April 12, 2021 11:21
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
targos added a commit that referenced this pull request May 1, 2021
@targos
doc: update links in ICU guide
c7c8722 
PR-URL: #38177
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@targos @danielleadams
doc: update links in ICU guide
b1830b5 
PR-URL: #38177
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@targos @benjamingr @cjihrig @gengjiawen @richardlau @nodejs-github-bot