Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix error message printing #38209

Closed
wants to merge 2 commits into from
Closed

repl: fix error message printing #38209

wants to merge 2 commits into from

Commits on Apr 12, 2021

  1. repl: fix error message printing 

    The REPL implementation would strip away the first and last character
of a formatted error message if it ended with `]` (but with the
obviously missing check for a starting `]`), leading to things like
`Uncaught rror: foo[a` being printed for input like `Error: foo[a]`.

Refs: nodejs#22436
    @addaleax
    addaleax committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    a482487 View commit details
    Browse the repository at this point in the history

  2. fixup! repl: fix error message printing 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @addaleax @aduh95
    addaleax and aduh95 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    2250427 View commit details
    Browse the repository at this point in the history