Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add the bootstrapped _depot_tools dir to the PATH (for V8 tests) #38299

Closed

Commits on Apr 19, 2021

  1. tools: add _depot_tools to PATH (for V8 tests)

    Ensures the `_depot_tools` dir bootstrapped during this script
    is added to the PATH, before `ninja` is executed,
    as `_depot_tools` already has a copy of `ninja` in it.
    This means one less system requirement to be able to run this script.
    
    (It seems like this was already intended to be on the PATH?)
    
    Note: This script is used by the `test-v8` Makefile target.
    DeeDeeG committed Apr 19, 2021
    Copy the full SHA
    8f74ee7 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Copy the full SHA
    98329ec View commit details
    Browse the repository at this point in the history
  2. tools: simplify getting DEPOT_TOOLS_DIR (V8 tests)

    Simplifies the script... Also finds _depot_tools relative to
    the current path, rather than relative to the repo root.
    
    This seems like a good idea, given that the rest of the script is also
    relative to the current path (`deps/v8`), not the repo root.
    DeeDeeG committed Apr 23, 2021
    Copy the full SHA
    ddb3f97 View commit details
    Browse the repository at this point in the history