Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document new TCP_KEEPCNT and TCP_KEEPINTVL socket option defaults #38313

Closed
wants to merge 2 commits into from
Closed

doc: document new TCP_KEEPCNT and TCP_KEEPINTVL socket option defaults #38313

wants to merge 2 commits into from

Commits on Apr 20, 2021

  1. doc: document new TCP_KEEPCNT and TCP_KEEPINTVL socket option defaults 

    PR nodejs#32204 introduced new defaults for the TCP keep-alive socket options (see deps/uv/src/unix/tcp.c):
- "TCP_KEEPCNT" now defaults to 10 on all platforms
- "TCP_KEEPINTVL" now defaults to 1 on all platforms

Previously, "TCP_KEEPCNT" and "TCP_KEEPINTVL" were not set explicitly and OS-default values were used.

Fixes: nodejs#38298
Refs: nodejs#32204
    @ArnoldZokas
    ArnoldZokas committed Apr 20, 2021
    Copy the full SHA
    95a4f96 View commit details
    Browse the repository at this point in the history

  2. update list of version where the change was introduced 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @ArnoldZokas @aduh95
    ArnoldZokas and aduh95 committed Apr 20, 2021
    Copy the full SHA
    90284aa View commit details
    Browse the repository at this point in the history