Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid deferred gc/cleanup for Buffer.from #38337

Closed
wants to merge 2 commits into from
Closed

src: avoid deferred gc/cleanup for Buffer.from #38337

wants to merge 2 commits into from

Commits on Apr 21, 2021

  1. src: avoid deferred gc/cleanup for Buffer.from 

    Previously, the code path would allocated a tracked ArrayBuffer
that defers cleanup and deallocation of the underlying data with
a SetImmediate. Avoid the unnecessary deferral by just allocating
a `BackingStore` directly and writing into it.

Fixes: nodejs#38300
Refs: nodejs#38336
    @jasnell
    jasnell committed Apr 21, 2021
    Copy the full SHA
    6805449 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. [Squash] nit 

    Co-authored-by: Anna Henningsen <anna@addaleax.net>
    @jasnell @addaleax
    jasnell and addaleax committed Apr 22, 2021
    Copy the full SHA
    f805a1e View commit details
    Browse the repository at this point in the history