Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix version history for "exports" patterns #38355

Closed
wants to merge 1 commit into from
Closed

doc: fix version history for "exports" patterns #38355

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 22, 2021 •
edited

It was removed from v12.19.0 release proposal: #35401 (comment)

Refs: #34718

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 22, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 22, 2021
jaydenseric added a commit to jaydenseric/test-director that referenced this pull request Apr 23, 2021
@jaydenseric
Correct the minimum supported Node.js version to v12.20.0.
37add29 
See nodejs/node#38355 .
@targos
Copy link
Member

targos commented Apr 25, 2021

Landed in dfc00ea

targos pushed a commit that referenced this pull request Apr 25, 2021
@aduh95 @targos
doc: fix version history for "exports" patterns
dfc00ea 
Refs: #34718

PR-URL: #38355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@targos targos closed this Apr 25, 2021
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2021
@aduh95 aduh95 deleted the exports-patterns-history branch April 25, 2021 08:00
targos pushed a commit that referenced this pull request Apr 29, 2021
@aduh95 @targos
doc: fix version history for "exports" patterns
a9314cd 
Refs: #34718

PR-URL: #38355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95 @targos
doc: fix version history for "exports" patterns
4274cb6 
Refs: #34718

PR-URL: #38355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
doc: fix version history for "exports" patterns
83b26b4 
Refs: #34718

PR-URL: #38355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
doc: fix version history for "exports" patterns
cede0c5 
Refs: #34718

PR-URL: #38355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

@Leko Leko Leko approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aduh95 @targos @guybedford @Leko @cjihrig @nodejs-github-bot