Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] fs: remove custom Buffer pool for streams #38397

Closed
wants to merge 1 commit into from

Commits on Apr 25, 2021

  1. fs: remove custom Buffer pool for streams

    The performance benefit of using a custom pool are negligable.
    Furthermore, it causes problems with Workers and transferrable.
    Rather than further adding complexity for compat with Workers,
    just remove the pooling logic.
    
    Refs: nodejs#33880 (comment)
    Fixes: nodejs#31733
    
    PR-URL: nodejs#33981
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    ronag authored and targos committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    0211c7a View commit details
    Browse the repository at this point in the history