Commits on Apr 28, 2021

1. tools: remove fixer for non-ascii-character ESLint custom rule …

   The fixer for non-ascii-character does not typidally do the right thing.
   It removes the entire node, not the offending character. I discovered
   this when it removed the entire contents of a file and I wasn't sure
   which auto-fix rule was doing it.
   
   This commit adds a minimal test for the rule. The tests require that
   auto-fix results be supplied, so if someone wants to re-add auto-fixing
   to the rule, we'll have tests that it does the right thing.
   
   PR-URL: nodejs#38413
   Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
   Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
   Reviewed-By: James M Snell <jasnell@gmail.com>

   

   Trott committed Apr 28, 2021
   Copy the full SHA

   896e5af View commit details

   Browse the repository at this point in the history