Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,readline: improve tab completion coverage #38465

Merged
merged 1 commit into from May 2, 2021
Merged

test,readline: improve tab completion coverage #38465

merged 1 commit into from May 2, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 29, 2021

Blocked on #38464

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Apr 29, 2021
@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 29, 2021
@aduh95 aduh95 added readline Issues and PRs related to the built-in readline module. needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Apr 29, 2021
@aduh95 aduh95 force-pushed the readline-tab-completion-test-coverage branch from b291d15 to 4e2ed40 Compare May 2, 2021 08:39
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels May 2, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37871/

@aduh95 aduh95 added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 2, 2021
@aduh95 aduh95 force-pushed the readline-tab-completion-test-coverage branch 2 times, most recently from b291d15 to b53eb32 Compare May 2, 2021 09:58
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels May 2, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37874/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37877/

@aduh95
test,readline: improve tab completion coverage
68e6673 
PR-URL: nodejs#38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95 aduh95 force-pushed the readline-tab-completion-test-coverage branch from b53eb32 to 68e6673 Compare May 2, 2021 13:05
@aduh95
Copy link
Contributor Author

aduh95 commented May 2, 2021

Landed in 68e6673

@aduh95 aduh95 merged commit 68e6673 into nodejs:master May 2, 2021
@aduh95 aduh95 deleted the readline-tab-completion-test-coverage branch May 2, 2021 13:06
targos pushed a commit that referenced this pull request May 3, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
16eb078 
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
4ce111b 
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
af74257 
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
dd8dc82 
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
bfe02b8 
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aduh95 @nodejs-github-bot @Trott @targos