[v14.x backport] stream: fix multiple Writable.destroy() calls #38473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
backport-38221-to-v14.x
branch
from
6531b98
to
a540afd
Compare
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Apr 29, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#38473
ronag
force-pushed
the
backport-38221-to-v14.x
branch
from
a540afd
to
33424e6
Compare
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Apr 29, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#38473
ronag
force-pushed
the
backport-38221-to-v14.x
branch
from
33424e6
to
fa4b816
Compare
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#38473
ronag
force-pushed
the
backport-38221-to-v14.x
branch
from
fa4b816
to
e516c0a
Compare
|
Not sure if there really is anything to backport here... |
What do you mean? Does it cherry-pick without conflicts? |
I mean that the only thing to backport is the test. The bug the commit fixes doesn't exist on 14.x. |
|
Ah, I see. I think the backport was requested because of the |
|
Do you know which commit/PR introduced the bug? |
|
Ah yes, it had the tag and when I tried to backport it didn't land cleanly. If there's nothing to backport, I guess we can just land the test if it covers the previous bug? |
danielleadams
force-pushed
the
v14.x-staging
branch
from
23ede20
to
f755fc4
Compare
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
|
Landed in 358ae8b |
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling Writable.destroy() multiple times in the same tick
could cause an assertion error.
Fixes: #38189
PR-URL: #38221
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Nitzan Uziely linkgoron@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com