Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: fix shutdown crashes #38492

Closed
wants to merge 6 commits into from
Closed

node-api: fix shutdown crashes #38492

wants to merge 6 commits into from

Commits on Apr 30, 2021

  1. node-api: fix shutdown crashes 

    Refs: nodejs/node-addon-api#906

Ensure that finalization is not defered during shutdown.
The env for the addon is deleted immediately after
iterating the list of finalizers to be run. Defering
causes crashes as the finalization uses the already
deleted env.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed Apr 30, 2021
    Copy the full SHA
    02f2879 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2021

  1. squash: add other place Finalization is deferred 

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed May 1, 2021
    Copy the full SHA
    d39704b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2021

  1. squash: ref/unref when using SetImmediate

    @mhdawson
    mhdawson committed May 2, 2021
    Copy the full SHA
    4033914 View commit details
    Browse the repository at this point in the history

  2. squash: fixup spacing

    @mhdawson
    mhdawson committed May 2, 2021
    Copy the full SHA
    0eeee2f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. squash: refactor - minimal change 

    - Refactor to limit changes needed to address
crashses seen.
- use exception safe approach to Ref/Unref env

Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed May 7, 2021
    Copy the full SHA
    f42e1f4 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. squash: rename to EnvRefHolder 

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed May 13, 2021
    Copy the full SHA
    558a765 View commit details
    Browse the repository at this point in the history