Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: fixes to bring things closer to lint compatibility #38529

Closed
wants to merge 4 commits into from
Closed

debugger: fixes to bring things closer to lint compatibility #38529

wants to merge 4 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 4, 2021

No description provided.

Trott added 3 commits May 3, 2021 20:29
@Trott
debugger: wrap lines longer than 80 chars
e6c71ac 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.
@Trott
debugger: avoid non-ASCII char in code file
8dfb0e5 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.
@Trott
debugger: disable only the lint rules required by current file state
1511724
@Trott Trott requested a review from aduh95 May 4, 2021 03:47
@github-actions github-actions bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels May 4, 2021
aduh95
aduh95 approved these changes May 4, 2021
View reviewed changes
lib/internal/inspector/inspect_repl.js Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented May 4, 2021

For info, I have a PR almost ready to integrate primordials to that file :)

@aduh95 aduh95 mentioned this pull request May 5, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37935/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2021
@jasnell
Copy link
Member

jasnell commented May 6, 2021

Landed in 75073ab...7eb28e3

@jasnell jasnell closed this May 6, 2021
jasnell pushed a commit that referenced this pull request May 6, 2021
@Trott @jasnell
debugger: wrap lines longer than 80 chars
d5f0c83 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: #38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 6, 2021
@Trott @jasnell
debugger: avoid non-ASCII char in code file
c42849f 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: #38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 6, 2021
@Trott @jasnell
debugger: disable only the lint rules required by current file state
7eb28e3 
PR-URL: #38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 17, 2021
@Trott @targos
debugger: wrap lines longer than 80 chars
d9867b9 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: #38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 17, 2021
@Trott @targos
debugger: avoid non-ASCII char in code file
e79f540 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: #38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 17, 2021
@Trott @targos
debugger: disable only the lint rules required by current file state
11dd9a6 
PR-URL: #38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
@Trott @aduh95
debugger: wrap lines longer than 80 chars
6a7cf5b 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
@Trott @aduh95
debugger: avoid non-ASCII char in code file
1dba93c 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
@Trott @aduh95
debugger: disable only the lint rules required by current file state
ec0566b 
PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 19, 2021
Closed
@richardlau
Copy link
Member

Backport to v14.x PR: #39446

aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: wrap lines longer than 80 chars
6ad28e0 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: avoid non-ASCII char in code file
64046b9 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: disable only the lint rules required by current file state
928128b 
PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: wrap lines longer than 80 chars
8b16b82 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: avoid non-ASCII char in code file
62131f6 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: disable only the lint rules required by current file state
d025841 
PR-URL: nodejs#38529
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: wrap lines longer than 80 chars
54c2b07 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: #38529
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: avoid non-ASCII char in code file
ec52826 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: #38529
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: disable only the lint rules required by current file state
fcbfb84 
PR-URL: #38529
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: wrap lines longer than 80 chars
ae90756 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: #38529
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: avoid non-ASCII char in code file
34659f2 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: #38529
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: disable only the lint rules required by current file state
b5724a1 
PR-URL: #38529
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 22, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: wrap lines longer than 80 chars
105043e 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: nodejs#38529
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: avoid non-ASCII char in code file
1081059 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: nodejs#38529
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: disable only the lint rules required by current file state
e706b8d 
PR-URL: nodejs#38529
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the tyson branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Trott @aduh95 @nodejs-github-bot @jasnell @richardlau @cjihrig @targos