Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: rename inspector-cli test module to debugger #38530

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
58 changes: 29 additions & 29 deletions test/common/README.md
Expand Up @@ -9,14 +9,14 @@ This directory contains modules used to test the Node.js implementation.
* [Common module API](#common-module-api)
* [Countdown module](#countdown-module)
* [CPU Profiler module](#cpu-profiler-module)
* [Debugger module](#debugger-module)
* [DNS module](#dns-module)
* [Duplex pair helper](#duplex-pair-helper)
* [Environment variables](#environment-variables)
* [Fixtures module](#fixtures-module)
* [Heap dump checker module](#heap-dump-checker-module)
* [hijackstdio module](#hijackstdio-module)
* [HTTP2 module](#http2-module)
* [Inspector CLI module](#inspector-cli-module)
* [Internet module](#internet-module)
* [ongc module](#ongc-module)
* [Report module](#report-module)
Expand Down Expand Up @@ -506,6 +506,34 @@ Sampling interval in microseconds.
Throws an `AssertionError` if there are no call frames with the expected
`suffix` in the profiling data contained in `file`.

## Debugger module

Provides common functionality for tests for `node inspect`.

### `startCLI(args[[, flags], spawnOpts])`

* `args` [<string>][]
* `flags` [<string>][] default = []
* `showOpts` [<Object>][] default = {}
* return [<Object>][]

Returns a null-prototype object with properties that are functions and getters
used to interact with the `node inspect` CLI. These functions are:

* `flushOutput()`
* `waitFor()`
* `waitForPrompt()`
* `waitForInitialBreak()`
* `breakInfo`
* `ctrlC()`
* `output`
* `rawOutput`
* `parseSourceLines()`
* `writeLine()`
* `command()`
* `stepCommand()`
* `quit()`

## `DNS` Module

The `DNS` module provides utilities related to the `dns` built-in module.
Expand Down Expand Up @@ -824,34 +852,6 @@ upon initial establishment of a connection.
socket.write(http2.kClientMagic);
```

## Inspector CLI module

Provides common functionality for tests for `node inspect`.

### `startCLI(args[[, flags], spawnOpts])`

* `args` [<string>][]
* `flags` [<string>][] default = []
* `showOpts` [<Object>][] default = {}
* return [<Object>][]

Returns a null-prototype object with properties that are functions and getters
used to interact with the `node inspect` CLI. These functions are:

* `flushOutput()`
* `waitFor()`
* `waitForPrompt()`
* `waitForInitialBreak()`
* `breakInfo`
* `ctrlC()`
* `output`
* `rawOutput`
* `parseSourceLines()`
* `writeLine()`
* `command()`
* `stepCommand()`
* `quit()`

## Internet Module

The `common/internet` module provides utilities for working with
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-address.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const { spawn } = require('child_process');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-auto-resume.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');
const { addLibraryPath } = require('../common/shared-lib-util');

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-backtrace.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-break.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-clear-breakpoints.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-custom-port.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-exceptions.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-exec-scope.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-exec.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-heap-profiler.js
Expand Up @@ -8,7 +8,7 @@ if (!common.isMainThread) {
}

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');
const tmpdir = require('../common/tmpdir');

tmpdir.refresh();
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-help.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-invalid-args.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const { createServer } = require('net');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-launch.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-low-level.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');
const assert = require('assert');

// Debugger agent direct access.
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-pid.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const { spawn } = require('child_process');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-preserve-breaks.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-profile.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-random-port.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-sb-before-load.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-scripts.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-use-strict.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector-cli/test-inspector-cli-watchers.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down