Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix error when writing buffers > INT32_MAX #38546

Closed
wants to merge 1 commit into from
Closed

fs: fix error when writing buffers > INT32_MAX #38546

wants to merge 1 commit into from

Commits on May 5, 2021

  1. fs: fix error when writing buffers > INT32_MAX 

    This reverts c380ee6. uv_fs_write returns an
int, so it is not possible to ask it to write more than INT32_MAX.

Instead, validate 'length' is an int32 in JS to avoid the assertion failure.
    @zbjornson
    zbjornson committed May 5, 2021
    Copy the full SHA
    13bbc14 View commit details
    Browse the repository at this point in the history