Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove dependency on distutils.spawn #38600

Merged
merged 1 commit into from May 10, 2021

Commits on May 10, 2021

  1. build: remove dependency on distutils.spawn

    Debian based packages of Python 3 do not include `distutils.spawn` and
    require an additional apt package to be installed (`python3-distutils`).
    Replace use of `distutils.spawn` with `shutil.which`, available in all
    versions of Python currently allowed by our configure scripts.
    
    For the `configure` script only, fall back to `distutils.spawn` to allow
    friendlier error messages when run on older unsupported versions of
    Python (e.g. 2.7).
    
    `configure.py` also uses `distutils.version` -- this appears to be
    available in Debian packaged Python 3 without installing
    `python3-distutils` so has been left as-is.
    
    PR-URL: nodejs#38600
    Refs: nodejs#30189
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richardlau committed May 10, 2021
    Copy the full SHA
    16982b6 View commit details
    Browse the repository at this point in the history