Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.12.1 #38628

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.12.1 #38628

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

v7.12.1 (2021-05-10)

BUG FIXES

DEPENDENCIES

  • 285976fd1 @npmcli/arborist@2.4.4
    • fix(reify): properly save spec if prerelease
  • f9f24d17c libnpmexec@1.1.1
    • fix(add): Specify 'en' locale to String.localeCompare
  • cb9f17499 glob@7.1.7
    • force 'en' locale in string sorting
  • 24b4e4a41 ignore-walk@3.0.4
    • Avoid locale-specific sorting issues
  • 1eb7e5c7d @npmcli/arborist@2.4.3
    • guard against locale-specific sorting
  • a6a826067 npm-packlist@2.2.2:
    • fix(sort): avoid locale-dependent sorting issues

v7.12.0 (2021-05-06)

FEATURES

BUG FIXES

DEPENDENCIES

  • d01ce5e13 libnpmexec@1.1.0:
    • feat: add walk up dir lookup to satisfy local bins
  • 81c1dfaaa @npmcli/arborist@2.4.2:
    • fix(add): save packages in the right place
    • fix(reify): do not clean up nodes with no parent
    • fix(audit): support alias specs & root package names
  • 87c2303ea @npmcli/git@2.0.9:
    • fix(clone): Do not allow git replacement objects by default
  • 99ff40dff npm-packlist@2.2.0:
    • feat(npmignore): Do not force include history, changelogs, notice
    • fix(package.json): add missing bin/index.js to files

@github-actions github-actions bot added needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels May 10, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@ruyadorno ruyadorno mentioned this pull request May 10, 2021
Closed
@ruyadorno ruyadorno added the fast-track PRs that do not need to wait for 48 hours to land. label May 10, 2021
@ruyadorno
Copy link
Member Author

fast-track ?

@github-actions
Copy link
Contributor

Fast-track has been requested by @ruyadorno. Please 👍 to approve.

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels May 10, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Trott
Trott approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38042/

MylesBorins
MylesBorins approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

ruyadorno added a commit that referenced this pull request May 12, 2021
@ruyadorno
deps: upgrade npm to 7.12.1
aefc621 
PR-URL: #38628
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@ruyadorno
Copy link
Member Author

Landed in aefc621

@ruyadorno ruyadorno closed this May 12, 2021
targos pushed a commit that referenced this pull request May 17, 2021
@ruyadorno @targos
deps: upgrade npm to 7.12.1
5c71f49 
PR-URL: #38628
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ruyadorno @nodejs-github-bot @jasnell @MylesBorins @Trott @lpinca @cjihrig @gireeshpunathil @trivikr