Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add workaround for V8 builds #38632

Merged
merged 1 commit into from May 12, 2021
Merged

build: add workaround for V8 builds #38632

merged 1 commit into from May 12, 2021
+6 −1

Commits on May 12, 2021

  1. build: add workaround for V8 builds 

    V8's build toolchain is not compatible with Python 3 and the CI job
that tests V8 needs to be run with Python 2. Add a fallback to
`find_executable` from `distutils.spawn` to allow the configure
script to run in the V8 test job.

PR-URL: nodejs#38632
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @richardlau
    richardlau committed May 12, 2021
    Copy the full SHA
    d206aa3 View commit details
    Browse the repository at this point in the history