Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.2.0 release proposal #38719

Merged
merged 86 commits into from May 19, 2021
Merged

v16.2.0 release proposal #38719

merged 86 commits into from May 19, 2021

Commits on May 14, 2021

  1. test: update OpenSSL 3.0.0-alpha15 error messages

    PR-URL: #38451
    Fixes: #38373
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev authored and richardlau committed May 14, 2021
    Copy the full SHA
    db5ee23 View commit details
    Browse the repository at this point in the history
  2. test: skip tests for openssl-3.0.0-alpha15

    This commit skips some test when OpenSSL 3.0.0-alpha15 is used as there
    is an issue that causes them to fail.
    
    This is only a temp solution until there is new OpenSSL release.
    
    Fixes: #38373
    
    PR-URL: #38451
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev authored and richardlau committed May 14, 2021
    Copy the full SHA
    b51b4fe View commit details
    Browse the repository at this point in the history
  3. deps: V8: cherry-pick 530080c44af2

        Original commit message:
        ```
        PPC: Add Power10 to the supported list and enable related features
    
        This CL adds Power10 recognition to Linux, AIX as well as IBMi.
    
        Enabled features include:
        MODULO
        FPR_GPR_MOV
        SIMD
        LWSYNC
        ISELECT
        VSX
    
        Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041
        Reviewed-by: Clemens Backes <clemensb@chromium.org>
        Reviewed-by: Junliang Yan <junyan@redhat.com>
        Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com>
        Commit-Queue: Milad Fa <mfarazma@redhat.com>
        Cr-Commit-Position: refs/heads/master@{#74279}
        ```
    
    Refs: v8/v8@530080c
    
    PR-URL: #38489
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    miladfarca authored and richardlau committed May 14, 2021
    Copy the full SHA
    f31a611 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. test: fix flaky inspector-cli tests when breakpionts are restored

    PR-URL: #38431
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    e64ebac View commit details
    Browse the repository at this point in the history
  2. test: move test-net-connect-econnrefused from pummel to sequential

    test-net-connect-econnrefused esems to run quickly on all platforms and
    does not appear to need to be in the pummel directory. Move to
    sequential.
    
    PR-URL: #38462
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    727c2bc View commit details
    Browse the repository at this point in the history
  3. doc: use sentence case in headers in src/crypto/README.md

    Use sentence case consistently in headers in src/crypto/README.md.
    
    PR-URL: #38524
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    38644d6 View commit details
    Browse the repository at this point in the history
  4. doc: corrected workload name as per the latest VS Installer

    PR-URL: #38500
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MrJithil authored and targos committed May 17, 2021
    Copy the full SHA
    9e10e1a View commit details
    Browse the repository at this point in the history
  5. doc: remove extraneous dash from flag prefix

    When rendered by `man node`, all flags have a dash prepended to them.
    Prior to this change, the man page would incorrectly read
    `---unhandled-rejections=mode`
    
    The three dashes is invalid syntax and rejected by the `node` command.
    
    PR-URL: #38532
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rhcarvalho authored and targos committed May 17, 2021
    Copy the full SHA
    e0118f3 View commit details
    Browse the repository at this point in the history
  6. build: compile with -std=gnu++14

    The name ‘gnu++1y’ is deprecated.
    
    Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html
    
    PR-URL: #38504
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RaisinTen authored and targos committed May 17, 2021
    Copy the full SHA
    03b4a3a View commit details
    Browse the repository at this point in the history
  7. tools: make GH Actions workflows work if default branch is not master

    PR-URL: #38516
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    1514885 View commit details
    Browse the repository at this point in the history
  8. test: run message and pseudo-tty tests in parallel

    PR-URL: #38502
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richardlau authored and targos committed May 17, 2021
    Copy the full SHA
    89e1dac View commit details
    Browse the repository at this point in the history
  9. doc: use AIX instead of Aix in fs.md

    Both for consistency within the doc and to conform with IBM's usage
    regarding their on product, refer to the operating system as AIX rather
    than Aix.
    
    PR-URL: #38535
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    e9d4c85 View commit details
    Browse the repository at this point in the history
  10. doc: fix broken AHAFS link in fs doc

    The content we're linking to for AHAFS was published in 2011 but has now
    been archived. This updates the link to the archived version (as the
    current version results in a "Yikes!" page with an HTTP 400 response
    code).
    
    Unfortunately, the archived version does say "This content is no
    longer being updated or maintained. The content is provided “as is.”
    Given the rapid evolution of technology, some content, steps, or
    illustrations may have changed." So we'll want to update at some point I
    imagine. But for the moment, archived content with a notice like that is
    better than a broken link.
    
    PR-URL: #38534
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    e59131d View commit details
    Browse the repository at this point in the history
  11. typings: add JSDoc typings for readline

    Added JSDoc typings for the `readline` lib module.
    
    PR-URL: #38253
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    VoltrexKeyva authored and targos committed May 17, 2021
    Copy the full SHA
    c0f0c9a View commit details
    Browse the repository at this point in the history
  12. doc: clarify DiffieHellmanGroup class docs

    Make it clearer in the docs that DiffieHellmanGroup does
    not support changing the keys after creation.
    
    PR-URL: #38363
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    Linkgoron authored and targos committed May 17, 2021
    Copy the full SHA
    ae9128e View commit details
    Browse the repository at this point in the history
  13. node-api: faster threadsafe_function

    Invoke threadsafe_function during the same tick and avoid marshalling
    costs between threads and/or churning event loop if either:
    
    1. There's a queued call already
    2. `Push()` is called while the main thread was running
       threadsafe_function
    
    PR-URL: #38506
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    indutny authored and targos committed May 17, 2021
    Copy the full SHA
    14a2a00 View commit details
    Browse the repository at this point in the history
  14. test: increase coverage for Blob

    Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/blob.js.html#L132
    
    PR-URL: #38515
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Lxxyx authored and targos committed May 17, 2021
    Copy the full SHA
    6622650 View commit details
    Browse the repository at this point in the history
  15. test: increase coverage for AbortController

    Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/abort_controller.js.html#L126
    
    PR-URL: #38514
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Lxxyx authored and targos committed May 17, 2021
    Copy the full SHA
    5b44107 View commit details
    Browse the repository at this point in the history
  16. test: complete coverage of querystring

    PR-URL: #38520
    Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/querystring.js.html#L179
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    pd4d10 authored and targos committed May 17, 2021
    Copy the full SHA
    f2f768f View commit details
    Browse the repository at this point in the history
  17. doc: use HEAD instead of master for links

    PR-URL: #38518
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    4c70e42 View commit details
    Browse the repository at this point in the history
  18. doc: fix code example in ecdh.setPublicKey()

    Fixes: #38540
    PR-URL: #38542
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    JBaczuk authored and targos committed May 17, 2021
    Copy the full SHA
    1d9fd49 View commit details
    Browse the repository at this point in the history
  19. lib: make IterableWeakMap safe to iterate

    PR-URL: #38523
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    cf4dc80 View commit details
    Browse the repository at this point in the history
  20. debugger: rename inspector-cli test module to debugger

    PR-URL: #38530
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    352a600 View commit details
    Browse the repository at this point in the history
  21. Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"

    This reverts commit 73370b4.
    
    The unit test is preserved to make sure it does not break
    #26463 again.
    
    PR-URL: #38510
    Fixes: #38499
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    juanarbol authored and targos committed May 17, 2021
    Copy the full SHA
    070ee4b View commit details
    Browse the repository at this point in the history
  22. src: make workers messaging more resilient

    PR-URL: #38510
    Fixes: #38499
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    juanarbol authored and targos committed May 17, 2021
    Copy the full SHA
    bfec80f View commit details
    Browse the repository at this point in the history
  23. debugger: wrap lines longer than 80 chars

    Wrap lines more than 80 chararcters long in inspect_repl.js so we can
    disable specific rules.
    
    PR-URL: #38529
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    d9867b9 View commit details
    Browse the repository at this point in the history
  24. debugger: avoid non-ASCII char in code file

    Avoid non-ASCII char in lib code as a single non-ASCII char forces all
    the chars to be stored inefficiently, bloating the binary size. This
    also brings the file closer to compatibility with our lint rules.
    
    PR-URL: #38529
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    e79f540 View commit details
    Browse the repository at this point in the history
  25. debugger: disable only the lint rules required by current file state

    PR-URL: #38529
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed May 17, 2021
    Copy the full SHA
    11dd9a6 View commit details
    Browse the repository at this point in the history
  26. fs: use assert in fsCall argument checking

    In the user perspective, it's not an arguemnt type error. Replace it
    with an `assert` expression.
    
    PR-URL: #38519
    Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/fs/promises.js.html#L268
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    pd4d10 authored and targos committed May 17, 2021
    Copy the full SHA
    47080bc View commit details
    Browse the repository at this point in the history
  27. test: improve fs coverage

    PR-URL: #38517
    Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/fs.js.html#L330
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    pd4d10 authored and targos committed May 17, 2021
    Copy the full SHA
    95db7d5 View commit details
    Browse the repository at this point in the history
  28. deps: V8: backport c0fceaa0669b

    Original commit message:
    
      Reland "[api] JSFunction PromiseHook for v8::Context"
    
      This is a reland of d5457f5fb7ea05ca05a697599ffa50d35c1ae3c7
      after a speculative revert.
    
      Additionally it fixes an issue with throwing promise hooks.
    
      Original change's description:
      > [api] JSFunction PromiseHook for v8::Context
      >
      > This will enable Node.js to get much better performance from async_hooks
      > as currently PromiseHook delegates to C++ for the hook function and then
      > Node.js delegates it right back to JavaScript, introducing several
      > unnecessary barrier hops in code that gets called very, very frequently
      > in modern, promise-heavy applications.
      >
      > This API mirrors the form of the original C++ function based PromiseHook
      > API, however it is intentionally separate to allow it to use JSFunctions
      > triggered within generated code to, as much as possible, avoid entering
      > runtime functions entirely.
      >
      > Because PromiseHook has internal use also, beyond just the Node.js use,
      > I have opted to leave the existing API intact and keep this separate to
      > avoid conflicting with any possible behaviour expectations of other API
      > users.
      >
      > The design ideas for this new API stemmed from discussion with some V8
      > team members at a previous Node.js Diagnostics Summit hosted by Google
      > in Munich, and the relevant documentation of the discussion can be found
      > here: https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/edit#heading=h.w1bavzz80l1e
      >
      > A summary of the reasons for why this new design is important can be
      > found here: https://docs.google.com/document/d/1vtgoT4_kjgOr-Bl605HR2T6_SC-C8uWzYaOPDK5pmRo/edit?usp=sharing
      >
      > Bug: v8:11025
      > Change-Id: I0b403b00c37d3020b5af07b654b860659d3a7697
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759188
      > Reviewed-by: Marja Hölttä <marja@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Anton Bikineev <bikineev@chromium.org>
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#73858}
    
      Bug: v8:11025
      Bug: chromium:1197475
      Change-Id: I73a71e97d9c3dff89a2b092c3fe4adff81ede8ef
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2823917
      Reviewed-by: Marja Hölttä <marja@chromium.org>
      Reviewed-by: Igor Sheludko <ishell@chromium.org>
      Reviewed-by: Anton Bikineev <bikineev@chromium.org>
      Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74071}
    
    Refs: v8/v8@c0fceaa
    
    PR-URL: #36394
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Qard authored and targos committed May 17, 2021
    Copy the full SHA
    827ae05 View commit details
    Browse the repository at this point in the history
  29. deps: V8: cherry-pick 272445f10927

    Original commit message:
    
        [runtime] Fix promise hooks
    
        promiseCapability can be undefined.
    
        Bug: v8:11025
        Bug: chromium:1201113
        Change-Id: I9da8764820cee0db1f0c38ed2fff0e3afeb9a80e
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844649
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#74117}
    
    Refs: v8/v8@272445f
    
    PR-URL: #36394
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Qard authored and targos committed May 17, 2021
    Copy the full SHA
    1a104ba View commit details
    Browse the repository at this point in the history
  30. deps: V8: cherry-pick 5f4413194480

    Original commit message:
    
        [promises] Change context promise hooks to Callable
    
        The previously added perf-context Promise-hooks take a v8::Function as
        arguments. However, the builtin code was only accepting JSFunctions
        which causes cast errors.
    
        Drive-by-fix: Directly pass nativeContext in more places.
    
        Bug: chromium:1201465
        Change-Id: Ic8bed11253a1f18a84e71eb9ea809b1ec1c3f428
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850162
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#74223}
    
    Refs: v8/v8@5f44131
    
    PR-URL: #36394
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Qard authored and targos committed May 17, 2021
    Copy the full SHA
    043b1aa View commit details
    Browse the repository at this point in the history
  31. deps: V8: cherry-pick 4c074516397b

    Original commit message:
    
        [promises] Fix slow path when context promise hooks are present
    
        Bug: chromium:1201936
        Change-Id: I1ee545e33587ddf4a5c7e1cbd64b53d36c75a146
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850936
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#74267}
    
    Refs: v8/v8@4c07451
    
    PR-URL: #36394
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Qard authored and targos committed May 17, 2021
    Copy the full SHA
    a84e9b3 View commit details
    Browse the repository at this point in the history
  32. deps: V8: cherry-pick fa4cb172cde2

    Original commit message:
    
        [runtime] Fix Promise.all context promise hooks
    
        We have to take the slow path in Promise.all if context promise hooks
        are set. The fast-path doesn't create intermediate promises by default.
    
        Bug: chromium:1204132, v8:11025
        Change-Id: Ide92de00a4f6df05e0ddbc8814f6673bd667f426
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2866771
        Reviewed-by: Victor Gomes <victorgomes@chromium.org>
        Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#74326}
    
    Refs: v8/v8@fa4cb17
    
    PR-URL: #36394
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Qard authored and targos committed May 17, 2021
    Copy the full SHA
    ab29872 View commit details
    Browse the repository at this point in the history
  33. async_hooks: use new v8::Context PromiseHook API

    PR-URL: #36394
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Qard authored and targos committed May 17, 2021
    Copy the full SHA
    36b9485 View commit details
    Browse the repository at this point in the history
  34. debugger: refactor to use internal modules

    This avoids loading the entirety of `node:util` and `node:url` and their
    dependencies while only a subset is actually used by this module.
    
    PR-URL: #38550
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    16a6c8d View commit details
    Browse the repository at this point in the history
  35. doc: typo stats() should be stat(); clarity

    PR-URL: #38541
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    700software authored and targos committed May 17, 2021
    Copy the full SHA
    56bf6c1 View commit details
    Browse the repository at this point in the history
  36. test: increase coverage for Histogram

    1. custom inspect test case
    Refs: https://coverage.nodejs.org/coverage-18e4f405b14b26f9/lib/internal/histogram.js.html#L56
    
    2. tests that RecordableHistogram is impossible to construct manually
    Refs: https://coverage.nodejs.org/coverage-18e4f405b14b26f9/lib/internal/histogram.js.html#L132
    
    PR-URL: #38555
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Lxxyx authored and targos committed May 17, 2021
    Copy the full SHA
    178fe21 View commit details
    Browse the repository at this point in the history
  37. deps: patch V8 to 9.0.257.25

    Refs: v8/v8@9.0.257.24...9.0.257.25
    
    PR-URL: #38556
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed May 17, 2021
    Copy the full SHA
    ec2dbfb View commit details
    Browse the repository at this point in the history
  38. buffer: remove unreachable code

    PR-URL: #38537
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    pd4d10 authored and targos committed May 17, 2021
    Copy the full SHA
    48b557e View commit details
    Browse the repository at this point in the history
  39. build: add missing torque output sources

    The `torque_generated_definitions` target is missing some torque
    generated files in its sources list when compared to the equivalent
    target in V8's BUILD.gn.
    
    PR-URL: #38576
    Fixes: #38571
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    richardlau authored and targos committed May 17, 2021
    Copy the full SHA
    10aaf30 View commit details
    Browse the repository at this point in the history
  40. test: call functions internally

    All (or at least most) of the tests uses lambdas (or arrow functions
    if you will) to call these functions internally inside of directly
    calling them, this should also use this technique for consistency.
    
    PR-URL: #38560
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    VoltrexKeyva authored and targos committed May 17, 2021
    Copy the full SHA
    8f78c66 View commit details
    Browse the repository at this point in the history
  41. meta: add v8 team

    PR-URL: #38566
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    gengjiawen authored and targos committed May 17, 2021
    Copy the full SHA
    90b640e View commit details
    Browse the repository at this point in the history
  42. buffer: remove TODOs in atob / btoa

    Refs: #38433 (comment)
    
    PR-URL: #38548
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    XadillaX authored and targos committed May 17, 2021
    Copy the full SHA
    dcae032 View commit details
    Browse the repository at this point in the history
  43. test: increase coverage for repl

    Refs: https://coverage.nodejs.org/coverage-7abc7e45b2e17730/lib/internal/repl.js.html#L33
    
    PR-URL: #38559
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Lxxyx authored and targos committed May 17, 2021
    Copy the full SHA
    16b2fb4 View commit details
    Browse the repository at this point in the history
  44. dgram: extract cluster lazy loading method to make it testable

    PR-URL: #38563
    Refs: https://coverage.nodejs.org/coverage-26e318a321a872bc/lib/dgram.js.html#L202
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    pd4d10 authored and targos committed May 17, 2021
    Copy the full SHA
    4001dd2 View commit details
    Browse the repository at this point in the history
  45. test,repl: fix tests when inspector is disabled

    Fixes: #38558
    
    PR-URL: #38564
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    24472d9 View commit details
    Browse the repository at this point in the history
  46. doc: fix fs.openSync() signature

    The `mode` argument depends on the `flags` argument but it is optional
    even if the `flags` argument is specified.
    
    PR-URL: #38591
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    lpinca authored and targos committed May 17, 2021
    Copy the full SHA
    d3de0ef View commit details
    Browse the repository at this point in the history
  47. build: remove dependency on distutils.spawn

    Debian based packages of Python 3 do not include `distutils.spawn` and
    require an additional apt package to be installed (`python3-distutils`).
    Replace use of `distutils.spawn` with `shutil.which`, available in all
    versions of Python currently allowed by our configure scripts.
    
    For the `configure` script only, fall back to `distutils.spawn` to allow
    friendlier error messages when run on older unsupported versions of
    Python (e.g. 2.7).
    
    `configure.py` also uses `distutils.version` -- this appears to be
    available in Debian packaged Python 3 without installing
    `python3-distutils` so has been left as-is.
    
    PR-URL: #38600
    Refs: #30189
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richardlau authored and targos committed May 17, 2021
    Copy the full SHA
    3bb12db View commit details
    Browse the repository at this point in the history
  48. fs: fix error when writing buffers > INT32_MAX

    This reverts c380ee6.
    uv_fs_write returns an int, so it is not possible to ask
    it to write more than INT32_MAX.
    
    Instead, validate 'length' is an int32 in JS to avoid
    the assertion failure.
    
    PR-URL: #38546
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    zbjornson authored and targos committed May 17, 2021
    Copy the full SHA
    e876118 View commit details
    Browse the repository at this point in the history
  49. module: add support for URL to import.meta.resolve

    PR-URL: #38587
    Refs: #38585
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    4c49027 View commit details
    Browse the repository at this point in the history
  50. build: add workaround for V8 builds

    V8's build toolchain is not compatible with Python 3 and the CI job
    that tests V8 needs to be run with Python 2. Add a fallback to
    `find_executable` from `distutils.spawn` to allow the configure
    script to run in the V8 test job.
    
    PR-URL: #38632
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and targos committed May 17, 2021
    Copy the full SHA
    b0df28d View commit details
    Browse the repository at this point in the history
  51. path: inline conditions

    This condition can be inlined in the first `if` statement since
    if the `path`'s length is 0, it'll be a empty string so we can
    return that as there's no need for an extra `if` statement.
    
    PR-URL: #38613
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    VoltrexKeyva authored and targos committed May 17, 2021
    Copy the full SHA
    be4b3a4 View commit details
    Browse the repository at this point in the history
  52. deps: upgrade npm to 7.12.1

    PR-URL: #38628
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    ruyadorno authored and targos committed May 17, 2021
    Copy the full SHA
    5c71f49 View commit details
    Browse the repository at this point in the history
  53. process: add 'worker' event

    Provides a new `process.on('worker', (worker) => {})` event that
    is triggered by the creation of a new `worker_thread.Worker`.
    The use case is to allow hooks to be installed for monitoring
    workers without having to modify the call sites around those.
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #38659
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    jasnell authored and targos committed May 17, 2021
    Copy the full SHA
    c182198 View commit details
    Browse the repository at this point in the history
  54. tools: add Worker to type-parser

    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #38659
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    jasnell authored and targos committed May 17, 2021
    Copy the full SHA
    ec8ab22 View commit details
    Browse the repository at this point in the history
  55. http: refactor to remove redundant argument of _deferToConnect

    PR-URL: #38598
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    pd4d10 authored and targos committed May 17, 2021
    Copy the full SHA
    3d8b8e1 View commit details
    Browse the repository at this point in the history
  56. test: improve coverage of lib/os.js

    PR-URL: #38653
    Refs: https://coverage.nodejs.org/coverage-52e4fb5b23157222/lib/os.js.html#L96
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    pd4d10 authored and targos committed May 17, 2021
    Copy the full SHA
    3d0fad3 View commit details
    Browse the repository at this point in the history
  57. build,src,test,doc: enable FIPS for OpenSSL 3.0

    This commit enables FIPS when Node.js is dynamically linking against
    quictls/openssl-3.0.
    
    BUILDING.md has been updated with instructions to configure and build
    quictls/openssl 3.0.0-alpha-15 and includes a couple of work-arounds
    which I believe are fixed in alpha-16 and can be removed when alpha-16
    is available. The information might be a little too detailed/verbose
    but I thought it would be helpful to at least initially include all the
    steps.
    
    PR-URL: #38633
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    danbev authored and targos committed May 17, 2021
    Copy the full SHA
    4296591 View commit details
    Browse the repository at this point in the history
  58. debugger: refactor inspect_repl to use primordials

    PR-URL: #38551
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    36bb724 View commit details
    Browse the repository at this point in the history
  59. test: improve coverage of lib/_http_client.js

    PR-URL: #38599
    Refs: https://coverage.nodejs.org/coverage-f37c26b8a2e10d0a/lib/_http_client.js.html#L200
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    pd4d10 authored and targos committed May 17, 2021
    Copy the full SHA
    5a0b521 View commit details
    Browse the repository at this point in the history
  60. doc: add ESM code examples in url.md

    PR-URL: #38651
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    6620a31 View commit details
    Browse the repository at this point in the history
  61. doc: change color of doctag on night mode

    Fixes: #38641
    
    PR-URL: #38652
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Ayase-252 authored and targos committed May 17, 2021
    Copy the full SHA
    c4b161c View commit details
    Browse the repository at this point in the history
  62. doc: update contact info

    Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
    PR-URL: #38689
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    gabrielschulhof authored and targos committed May 17, 2021
    Copy the full SHA
    1765e32 View commit details
    Browse the repository at this point in the history
  63. deps: upgrade npm to 7.13.0

    PR-URL: #38682
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    ruyadorno authored and targos committed May 17, 2021
    Copy the full SHA
    608d0e1 View commit details
    Browse the repository at this point in the history
  64. repl: fix Ctrl+C on top level await

    PR-URL: #38656
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    aduh95 authored and targos committed May 17, 2021
    Copy the full SHA
    e2b8454 View commit details
    Browse the repository at this point in the history
  65. src: remove extra semi after member fn

    PR-URL: #38686
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    codebytere authored and targos committed May 17, 2021
    Copy the full SHA
    6b409cf View commit details
    Browse the repository at this point in the history
  66. tools: update ESLint to 7.26.0

    Update ESLint to 7.26.0
    
    PR-URL: #38605
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and targos committed May 17, 2021
    Copy the full SHA
    a028805 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. crypto: forbid NODE-ED25519 and NODE-ED448 "raw" key export

    closes #38655
    
    PR-URL: #38668
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    panva authored and targos committed May 18, 2021
    Copy the full SHA
    36bb8da View commit details
    Browse the repository at this point in the history
  2. util: add util.types.isKeyObject and util.types.isCryptoKey

    closes #38611
    
    PR-URL: #38619
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and targos committed May 18, 2021
    Copy the full SHA
    fbf02e3 View commit details
    Browse the repository at this point in the history
  3. src: update cares_wrap OpenBSD defines

    Move the `#define`s back into `cares_wrap.cc`, as they are part of
    the implementation, not the declarations used in `cares_wrap.h`,
    and apply the suggestion from
    #38572 (comment)
    to make the defines a bit more generic and not check for OpenBSD
    specifically.
    
    Refs: #38572
    
    PR-URL: #38670
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and targos committed May 18, 2021
    Copy the full SHA
    524a9d6 View commit details
    Browse the repository at this point in the history
  4. lib: support setting process.env.TZ on windows

    Fixes: #4230
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #38642
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    jasnell authored and targos committed May 18, 2021
    Copy the full SHA
    c0deeea View commit details
    Browse the repository at this point in the history
  5. doc: clarify synchronous blocking of Worker stdio

    Fixes: #25630
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #38658
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and targos committed May 18, 2021
    Copy the full SHA
    5c38a55 View commit details
    Browse the repository at this point in the history
  6. fs: fix async iterator partial writes

    fix an issue where chunks might be partially written when
    using writeFile with an async iterator.
    
    PR-URL: #38615
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Linkgoron authored and targos committed May 18, 2021
    Copy the full SHA
    3a5856c View commit details
    Browse the repository at this point in the history
  7. errors: remove input from ERR_INVALID_URL message

    Avoid potentially huge messages and leaked secrets.
    
    PR-URL: #38614
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    moander authored and targos committed May 18, 2021
    Copy the full SHA
    347b9f2 View commit details
    Browse the repository at this point in the history
  8. doc: add documentation for fs.WriteStream.close()

    PR-URL: #38610
    Fixes: #38606
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    ihiteshsharma authored and targos committed May 18, 2021
    Copy the full SHA
    0100a3b View commit details
    Browse the repository at this point in the history
  9. test: set common.bits to 64 for riscv64

    PR-URL: #38626
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    andreas-schwab authored and targos committed May 18, 2021
    Copy the full SHA
    5b25fbe View commit details
    Browse the repository at this point in the history
  10. doc: update abort signal in fs promise api example

    PR-URL: #38669
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    MoritzKn authored and targos committed May 18, 2021
    Copy the full SHA
    8590c15 View commit details
    Browse the repository at this point in the history
  11. events: use nullish coalencing operator

    PR-URL: #38328
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    VoltrexKeyva authored and targos committed May 18, 2021
    Copy the full SHA
    5b40e2f View commit details
    Browse the repository at this point in the history
  12. test: stream.finished detects a destroyed IncomingMessage

    Add a test to verify that stream.finished works correctly
    on IncomingMessage
    
    refs: #38657
    
    PR-URL: #38661
    Refs: #38657
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Linkgoron authored and targos committed May 18, 2021
    Copy the full SHA
    8eea317 View commit details
    Browse the repository at this point in the history
  13. test: refactor test-readline-interface to be shorter

    PR-URL: #38691
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    juanarbol authored and targos committed May 18, 2021
    Copy the full SHA
    ff1b432 View commit details
    Browse the repository at this point in the history
  14. doc: document buffer.kStringMaxLength

    PR-URL: #38688
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed May 18, 2021
    Copy the full SHA
    a0dc194 View commit details
    Browse the repository at this point in the history
  15. src: fix fatal errors when a current isolate not exist

    napi_fatal_error and node watchdog trigger fatal error but rather
    running on a thread that hold no current isolate.
    
    PR-URL: #38624
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and targos committed May 18, 2021
    Copy the full SHA
    718ad10 View commit details
    Browse the repository at this point in the history
  16. tools: remove redundant v8 config

    PR-URL: #38565
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    gengjiawen authored and targos committed May 18, 2021
    Copy the full SHA
    267a84f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. 2021-05-19, Version 16.2.0 (Current)

    Notable changes:
    
    async_hooks:
      * (SEMVER-MINOR) use new v8::Context PromiseHook API (Stephen Belanger) #36394
    lib:
      * support setting process.env.TZ on windows (James M Snell) #38642
    module:
      * (SEMVER-MINOR) add support for `URL` to `import.meta.resolve` (Antoine du Hamel) #38587
    process:
      * (SEMVER-MINOR) add `'worker'` event (James M Snell) #38659
    util:
      * (SEMVER-MINOR) add util.types.isKeyObject and util.types.isCryptoKey (Filip Skokan) #38619
    
    PR-URL: #38719
    targos committed May 19, 2021
    Copy the full SHA
    6e69f84 View commit details
    Browse the repository at this point in the history