Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: reduce scope of eslint disable comment #38946

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Commits on Jun 8, 2021

  1. debugger: reduce scope of eslint disable comment

    Current code masks setInterval and setTimeout with promisified versions.
    This can be confusing to read and causes lint errors. Replace masking
    with use of pSetInterval and pSetTimeout instead.
    
    Move disabling of lint rule from entire file to the one remaining line
    (after the above changes) that still needs it.
    
    PR-URL: nodejs#38946
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    fa86b36 View commit details
    Browse the repository at this point in the history