Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't pass python override to V8 build #38969

Closed
wants to merge 1 commit into from
Closed

build: don't pass python override to V8 build #38969

wants to merge 1 commit into from
+13 −4

Commits on Jun 8, 2021

  1. build: don't pass python override to V8 build 

    If the `configure.py` script is executed by a Python binary that is
not the one on the PATH it will create a `python` symlink in
`out/tools/bin` and prefix that to the PATH so it is used instead of
the one that otherwise would have been found on the PATH. This is
done so that gyp scripts shelling out to `python` execute with the
same version of Python as used to run the configure script.

V8's build uses V8's build toolchain (i.e. not gyp) and currently that
is incompatible with Python 3. Prevent prefixing the PATH for the V8
build so that it picks up `python` from the unprefixed PATH. This will
allow us to build Node.js with Python 3 but still use Python 2 to build
V8 in the CI.
    @richardlau
    richardlau committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    6dae709 View commit details
    Browse the repository at this point in the history