Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: split NodeMainInstance::Run() and move handle checking code to the snapshot builder #39007

Closed
wants to merge 3 commits into from
Closed

bootstrap: split NodeMainInstance::Run() and move handle checking code to the snapshot builder #39007

wants to merge 3 commits into from

Commits on Jun 11, 2021

  1. bootstrap: split NodeMainInstance::Run() 

    Split the running of the instance so that it can be reused
by the snapshot builder when we need to run the loop for
user code.
    @joyeecheung
    joyeecheung committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    2ee344b View commit details
    Browse the repository at this point in the history

  2. bootstrap: move event loop handle checking into snapshot builder 

    This is only necessary for the snapshot builder (because we
have no way to resurrect the handles at the moment). In addition,
print the handles if the debug flag is set or if the queues
are not empty after snapshot is created.
    @joyeecheung
    joyeecheung committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    d73a4d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. fixup! bootstrap: move event loop handle checking into snapshot builder 

    Co-authored-by: Voltrex <mohammadkeyvanzade94@gmail.com>
    @joyeecheung @VoltrexKeyva
    joyeecheung and VoltrexKeyva committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    767278e View commit details
    Browse the repository at this point in the history