Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo in test-http2-invalidheaderfield.js #39021

Closed
wants to merge 1 commit into from
Closed

test: fix typo in test-http2-invalidheaderfield.js #39021

wants to merge 1 commit into from

Conversation

eltociear
Copy link
Contributor

Psuedo -> Pseudo

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 13, 2021
@RaisinTen RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 13, 2021 •
edited by jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/38611/ 💚

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 13, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 14, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@jasnell
Copy link
Member

jasnell commented Jun 14, 2021

Landed in 7e99dbc

@jasnell jasnell closed this Jun 14, 2021
jasnell pushed a commit that referenced this pull request Jun 14, 2021
@eltociear @jasnell
test: fix typo in test-http2-invalidheaderfield.js
7e99dbc 
Psuedo -> Pseudo

PR-URL: #39021
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 15, 2021
@eltociear @danielleadams
test: fix typo in test-http2-invalidheaderfield.js
d50df5d 
Psuedo -> Pseudo

PR-URL: #39021
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 15, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
@eltociear @danielleadams
test: fix typo in test-http2-invalidheaderfield.js
da254c8 
Psuedo -> Pseudo

PR-URL: #39021
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau
Copy link
Member

The test being fixed was added by a semver-major PR (#33161) so marking as dont-land-on-v14.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@eltociear @nodejs-github-bot @jasnell @richardlau @lpinca @cjihrig @RaisinTen