Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger,errors: add ERR_DEBUGGER errors and use them in the former node-inspect code #39024

Merged
merged 5 commits into from Jun 16, 2021
Merged

debugger,errors: add ERR_DEBUGGER errors and use them in the former node-inspect code #39024

merged 5 commits into from Jun 16, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 13, 2021

No description provided.

@github-actions github-actions bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Jun 13, 2021
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed errors Issues and PRs related to JavaScript errors originated in Node.js core. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Jun 13, 2021
@Trott Trott requested review from aduh95 and jkrems June 13, 2021 13:00
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38610/

aduh95
aduh95 approved these changes Jun 13, 2021
View reviewed changes
lib/internal/inspector/inspect_repl.js Outdated Show resolved Hide resolved
@Trott Trott force-pushed the lint-debug branch 2 times, most recently from 44f2581 to 39a6c2c Compare June 13, 2021 19:13
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38617/

@Trott Trott added errors Issues and PRs related to JavaScript errors originated in Node.js core. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Jun 14, 2021
@Trott
errors: add ERR_DEBUGGER_ERROR
787cacc 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@Trott
debugger: use ERR_DEBUGGER_ERROR in debugger client
c22eec8 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@Trott
debugger: use error codes in debugger REPL
fa009e1 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@Trott
errors: add ERR_DEBUGGER_STARTUP_ERROR
6dbff83 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@Trott
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
7679960 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 16, 2021

Landed in f4609bd...7679960

@Trott Trott merged commit 7679960 into nodejs:master Jun 16, 2021
@Trott Trott deleted the lint-debug branch June 16, 2021 01:43
@richardlau
Copy link
Member

Backport to v14.x PR: #39446

aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
errors: add ERR_DEBUGGER_ERROR
04c7c79 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: use ERR_DEBUGGER_ERROR in debugger client
c25a96e 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: use error codes in debugger REPL
a4399ec 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
errors: add ERR_DEBUGGER_STARTUP_ERROR
2d5fd94 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
2fb062f 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
errors: add ERR_DEBUGGER_ERROR
7a5e902 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: use ERR_DEBUGGER_ERROR in debugger client
beb3dce 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: use error codes in debugger REPL
a4c42b5 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
errors: add ERR_DEBUGGER_STARTUP_ERROR
584f779 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
@Trott @aduh95
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
f5dd504 
PR-URL: nodejs#39024
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
errors: add ERR_DEBUGGER_ERROR
013da6e 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: use ERR_DEBUGGER_ERROR in debugger client
81bf4c6 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: use error codes in debugger REPL
e2a7104 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
errors: add ERR_DEBUGGER_STARTUP_ERROR
8132bf1 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
0568a27 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
errors: add ERR_DEBUGGER_ERROR
cfccf13 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: use ERR_DEBUGGER_ERROR in debugger client
a3991d7 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: use error codes in debugger REPL
5d4d23d 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
errors: add ERR_DEBUGGER_STARTUP_ERROR
9b993ed 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@Trott @richardlau
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
b7ee9d8 
PR-URL: #39024
Backport-PR-URL: #39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@richardlau richardlau mentioned this pull request Jul 22, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
errors: add ERR_DEBUGGER_ERROR
af9e841 
PR-URL: nodejs#39024
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: use ERR_DEBUGGER_ERROR in debugger client
753e2be 
PR-URL: nodejs#39024
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: use error codes in debugger REPL
3b1ab39 
PR-URL: nodejs#39024
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
errors: add ERR_DEBUGGER_STARTUP_ERROR
bb38c19 
PR-URL: nodejs#39024
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
99cb640 
PR-URL: nodejs#39024
Backport-PR-URL: nodejs#39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@jkrems jkrems jkrems approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Trott @nodejs-github-bot @richardlau @jkrems @lpinca @aduh95 @VoltrexKeyva @targos