Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: use missing validator #39028

Merged
merged 1 commit into from Jun 26, 2021
Merged

fs: use missing validator #39028

merged 1 commit into from Jun 26, 2021

Commits on Jun 26, 2021

  1. fs: allow empty string for temp directory prefix

    The `fs` lib module's `mkdtemp()` and `mkdtempSync()` methods were
    missing a validator, and weren't allowing the empty string as a valid
    prefix.
    
    PR-URL: nodejs#39028
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    VoltrexKeyva authored and aduh95 committed Jun 26, 2021
    Copy the full SHA
    1317252 View commit details
    Browse the repository at this point in the history