Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] deps: restore minimum ICU version to 65 #39068

Closed
wants to merge 1 commit into from

Commits on Jul 12, 2021

  1. deps: restore minimum ICU version to 65

    This modifies 40df0dc so that the changes it applies are only used
    if ICU 67 or greater is used, and restores the previous code path for
    versions of ICU below 67.
    
    The minimum ICU version was bumped to 67 in Node.js 14.6.0 by
    nodejs#34356 but the referenced V8
    commit[1] isn't on `v14.x-staging` and appears to have been reverted
    on V8 8.4[2] so this PR also restores the minimum ICU version to 65.
    
    [1] v8/v8@611e412
    [2] v8/v8@eeccede
    richardlau committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    fba278c View commit details
    Browse the repository at this point in the history