Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pass directory instead of list of files to js2c.py #39069

Closed
wants to merge 1 commit into from

Commits on Jun 21, 2021

  1. build: pass directory instead of list of files to js2c.py

    On Windows there is a limit to the length of commands, so there
    will be an error once the lengths of the JS file names combined
    exceed that limit. This patch modifies js2c.py so that
    it now takes a --directory argument to glob for .js and
    .mjs files in addition to the list of files passed directly.
    We still pass the additional files we include from deps/
    directly through the command line, as we only includes some of
    them so we cannot simply glob, but those are limited so listing
    them out should be fine.
    
    Refs: https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation
    joyeecheung committed Jun 21, 2021
    Copy the full SHA
    b34d506 View commit details
    Browse the repository at this point in the history