Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: check for empty contexts before removing #39095

Closed
wants to merge 3 commits into from
Closed

async_hooks: check for empty contexts before removing #39095

wants to merge 3 commits into from

Commits on Jun 19, 2021

  1. async_hooks: check for empty contexts before removing 

    This way we don't end up attempting to SetPromiseHooks on contexts that
have already been collected.

Fixes: nodejs#39019
    @bengl
    bengl committed Jun 19, 2021
    Copy the full SHA
    1a401e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. fixup! review feedback 

    Co-authored-by: Anna Henningsen <github@addaleax.net>
    @bengl @addaleax
    bengl and addaleax committed Jun 21, 2021
    Copy the full SHA
    979bd0b View commit details
    Browse the repository at this point in the history

  2. fixup! check for empty contexts in SetJSPromiseHooks too

    @bengl
    bengl committed Jun 21, 2021
    Copy the full SHA
    9acb32f View commit details
    Browse the repository at this point in the history