Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: eliminate native PromiseHook #39135

Closed
wants to merge 4 commits into from
Closed

async_hooks: eliminate native PromiseHook #39135

wants to merge 4 commits into from

Commits on Jul 5, 2021

  1. async_hooks: eliminate native PromiseHook

    @Qard
    Qard committed Jul 5, 2021
    Copy the full SHA
    cb99784 View commit details
    Browse the repository at this point in the history

  2. async_hooks: emit promise trace events from JS

    @Qard
    Qard committed Jul 5, 2021
    Copy the full SHA
    e469ca6 View commit details
    Browse the repository at this point in the history

  3. domain: do not add domain to promise from other context

    @Qard
    Qard committed Jul 5, 2021
    Copy the full SHA
    f76d251 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. lib: comment explaining special-case handling of promises 

    Promise handling is special-cased for domains and trace_events.
Domains must not add the `domain` property to promises in other
contexts, and trace_events must be emitted from JavaScript as
promises no longer have an AsyncWrap type attached to them.
    @Qard
    Qard committed Jul 21, 2021
    Copy the full SHA
    e8b19b3 View commit details
    Browse the repository at this point in the history