Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: shorten path used in tarball build workflow #39192

Closed
wants to merge 1 commit into from

Commits on Jun 29, 2021

  1. build: shorten path used in tarball build workflow

    Shorten the path to the workspace for the GitHub Actions `build-tarball`
    workflow to avoid `execvp: printf: Argument list too long` errors from
    `make`.
    
    GitHub currently runs workflows in a `/home/runner/work/my-repo/my-repo`
    directory where `my-repo` is the repository name and is repeated twice
    (the second is from the git checkout). Some of the command lines in the
    Node.js build, e.g. the `ar` command to create static libraries, pass
    several fully qualified paths to filenames so the workflow directory is
    repeat many times. The most recent V8 update added more files to the
    command and has now tipped the command line length over the maximum
    allowed when using forks of the `node` repository with a longer name
    (e.g. `node-auto-test` and the private fork used to prepare security
    releases).
    
    Use GitHub's `RUNNER_TEMP` environment variable to extract the source
    tarball into the temporary directory on the GitHub runner. This is
    currently `/home/runner/work/_temp` and is not dependent on the name
    of the repository.
    richardlau committed Jun 29, 2021
    Copy the full SHA
    7cf157e View commit details
    Browse the repository at this point in the history