Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] Backport V8 changes to remove set_sources_assignment_filter #39244

Closed
wants to merge 6 commits into from
Closed

[v14.x] Backport V8 changes to remove set_sources_assignment_filter #39244

wants to merge 6 commits into from

Commits on Jul 9, 2021

  1. deps: V8: backport 1b1eda0876aa 

    Original commit message:

    tracing: Update proto library build rule and roll Perfetto

    This patch removes use of the deprecated sources_assignment_filter GN
    feature from gni/proto_library.gni, since the extra descriptor files are
    no longer being generated.

    We also roll Perfetto to match the version used in Chrome and update
    test expectations accordingly.

    Bug: v8:10995
    Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70381}

Refs: v8/v8@1b1eda0
    @targos
    targos committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    cccf141 View commit details
    Browse the repository at this point in the history

  2. deps: V8: cherry-pick 92e6d3317082 

    Original commit message:

    build: Remove no-op calls to set_sources_assignment_filter

    Chromiun no longer use set_sources_assignment_filter() anywhere in the
    build, so these are no longer needed.

    Bug: chromium:1018739
    Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70405}

Refs: v8/v8@92e6d33
    @targos
    targos committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    ad18fcd View commit details
    Browse the repository at this point in the history

  3. deps: V8: cherry-pick 7c182bd65f42 

    Original commit message:

    Fix visiblity rules for configs enforced by the latest GN version.

    Prior versions of GN had a bug (gn:22) where visibility rules
    for configs weren't being enforced properly.

    This CL tweaks the visibility settings of some configs to
    conform to the latest version.

    Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
    Commit-Queue: Dirk Pranke <dpranke@google.com>
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69463}

Refs: v8/v8@7c182bd
    @targos
    targos committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    959b466 View commit details
    Browse the repository at this point in the history

  4. deps: V8: cherry-pick 0b3a4ecf7083 

    Original commit message:

    Fix implicit conversion loses integer precision warning

    The type of m is long in 64 bits build, and results implicit conversion
    loses integer precision, which was found by improved clang warning
    (-Wshorten-64-to-32)

    Bug: chromium:1124085
    Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323
    Commit-Queue: Zequan Wu <zequanwu@google.com>
    Auto-Submit: Zequan Wu <zequanwu@google.com>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69686}

Refs: v8/v8@0b3a4ec
    @targos
    targos committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    1c000c2 View commit details
    Browse the repository at this point in the history

  5. deps: V8: cherry-pick 895949419186 

    Original commit message:

    Add -Wno-string-concatenation to test/cctest:cctest_sources

    v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.

    Bug: chromium:1114873
    Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
    Commit-Queue: Arthur Eubanks <aeubanks@google.com>
    Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69625}

Refs: v8/v8@8959494
    @targos
    targos committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    882da88 View commit details
    Browse the repository at this point in the history

  6. deps: V8: update build dependencies 

    These updates are necessary to build V8 with recent GN versions.
    @targos
    targos committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    b3c9546 View commit details
    Browse the repository at this point in the history