-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14.x backport] deps: update to cjs-module-lexer@1.2.2 #39421
[v14.x backport] deps: update to cjs-module-lexer@1.2.2 #39421
Conversation
8ea39c6
to
4ac719f
Compare
PR-URL: nodejs#39402 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
c4e7a0d
to
88046f2
Compare
Not sure what's going on with this CI run here, but this should still be good to merge I believe. Are there known issues with the 14 builds? |
Landed in ac76cdb. |
@guybedford this landed a bit pre-maturely. The original change hasn't yet gone out in a 16.x release and we need it to be out on Current for at least 2 weeks before backporting. Generally I've avoided landing changes that are not yet ready for backport to avoid it accidentally going out pre-maturely in an LTS release |
Thanks @MylesBorins I've reverted and reopened this in #39531. |
Backports #39402 for Node.js 14.x.
@nodejs/modules