Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] Fix build with ICU >= 68. #39440

Closed
wants to merge 1 commit into from
Closed

[v12.x] Fix build with ICU >= 68. #39440

wants to merge 1 commit into from

Conversation

jameshilliard
Copy link

@github-actions github-actions bot added needs-ci PRs that need a full CI run. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Jul 19, 2021
@richardlau richardlau changed the title Fix build with ICU >= 68. [v12.x] Fix build with ICU >= 68. Jul 19, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jul 19, 2021

Is it the same as v8/v8@035c305? If so, can you apply the upstream commit instead (git node v8 backport 035c305ce7761f51328b45f1bd83e26aef267c9d). See https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-branches for detailed instructions.

@richardlau
Copy link
Member

Is it the same as v8/v8@035c305? If so, can you apply the upstream commit instead (git node v8 backport 035c305ce7761f51328b45f1bd83e26aef267c9d). See https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-branches for detailed instructions.

For history, we had to patch up v8/v8@035c305 for 14.x so that LTS Node.js could continue to build against the existing ICU versions #39068.

@jameshilliard
Copy link
Author

Is it the same as v8/v8@035c305?

I think so, but I tried to maintain backwards compat with older ICU versions.

@jameshilliard
Copy link
Author

For history, we had to patch up v8/v8@035c305 for 14.x so that LTS Node.js could continue to build against the existing ICU versions #39068.

Made a version based on that in #39451 in case that's preferable.

@jameshilliard @richardlau
Fix build with ICU >= 68.
34a9207 
Adapted from:
https://chromium-review.googlesource.com/c/v8/v8/+/2477751

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39237/

@richardlau
Copy link
Member

I've landed #39451 instead. Thanks.

@richardlau richardlau closed this Jul 23, 2021
@jameshilliard jameshilliard deleted the fix-icu-68 branch July 23, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jameshilliard @aduh95 @richardlau @nodejs-github-bot