New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14.x backport] debugger patches #39446
Commits on Jul 20, 2021
-
lib: add primordials.SafeArrayIterator
PR-URL: nodejs#36532 Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c53b4ad - Browse repository at this point
Copy the full SHA c53b4adView commit details -
Revert "debugger: rename internal library for clarity"
This reverts commit d0c7ab0.
Configuration menu - View commit details
-
Copy full SHA for 1355e52 - Browse repository at this point
Copy the full SHA 1355e52View commit details -
debugger: add usage example for
--port
PR-URL: nodejs#38400 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7b5e17f - Browse repository at this point
Copy the full SHA 7b5e17fView commit details -
debugger: refactor
internal/inspector/_inspect
to use more primordialsPR-URL: nodejs#38406 Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8146a8c - Browse repository at this point
Copy the full SHA 8146a8cView commit details -
debugger: wait for V8 debugger to be enabled
Refs: nodejs#38273 (comment) PR-URL: nodejs#38811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cc589f3 - Browse repository at this point
Copy the full SHA cc589f3View commit details -
debugger: revise async iterator usage to comply with lint rules
I'm not sure that this is any clearer than the existing code, but I don't think it's significantly less clear, and it avoids comment disabling a lint rule. PR-URL: nodejs#38847 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e036082 - Browse repository at this point
Copy the full SHA e036082View commit details -
debugger: reduce scope of eslint disable comment
Current code masks setInterval and setTimeout with promisified versions. This can be confusing to read and causes lint errors. Replace masking with use of pSetInterval and pSetTimeout instead. Move disabling of lint rule from entire file to the one remaining line (after the above changes) that still needs it. PR-URL: nodejs#38946 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e622105 - Browse repository at this point
Copy the full SHA e622105View commit details -
debugger: enable linter on
internal/inspector/inspect_client
PR-URL: nodejs#38417 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9b960d9 - Browse repository at this point
Copy the full SHA 9b960d9View commit details -
debugger: remove unnecessary boilerplate copyright comment
PR-URL: nodejs#38952 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5ae4a50 - Browse repository at this point
Copy the full SHA 5ae4a50View commit details -
debugger: align message with Node.js standard
Node.js uses (or will use) _Ctrl+C_ with no spaces. To unify the messages from inspect with other messages from the REPL and elsewhere, make that change in node-inspect too. PR-URL: nodejs#38400 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ccc69e0 - Browse repository at this point
Copy the full SHA ccc69e0View commit details -
debugger: wrap lines longer than 80 chars
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8b16b82 - Browse repository at this point
Copy the full SHA 8b16b82View commit details -
debugger: avoid non-ASCII char in code file
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 62131f6 - Browse repository at this point
Copy the full SHA 62131f6View commit details -
debugger: disable only the lint rules required by current file state
PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d025841 - Browse repository at this point
Copy the full SHA d025841View commit details -
debugger: refactor to use internal modules
This avoids loading the entirety of `node:util` and `node:url` and their dependencies while only a subset is actually used by this module. PR-URL: nodejs#38550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e86361a - Browse repository at this point
Copy the full SHA e86361aView commit details -
debugger: refactor
inspect_repl
to use primordialsPR-URL: nodejs#38551 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 22320ed - Browse repository at this point
Copy the full SHA 22320edView commit details -
debugger: removed unused function argument
PR-URL: nodejs#38850 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f41d010 - Browse repository at this point
Copy the full SHA f41d010View commit details -
errors: add ERR_DEBUGGER_ERROR
PR-URL: nodejs#39024 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7a5e902 - Browse repository at this point
Copy the full SHA 7a5e902View commit details -
debugger: use ERR_DEBUGGER_ERROR in debugger client
PR-URL: nodejs#39024 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for beb3dce - Browse repository at this point
Copy the full SHA beb3dceView commit details -
debugger: use error codes in debugger REPL
PR-URL: nodejs#39024 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a4c42b5 - Browse repository at this point
Copy the full SHA a4c42b5View commit details -
errors: add ERR_DEBUGGER_STARTUP_ERROR
PR-URL: nodejs#39024 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 584f779 - Browse repository at this point
Copy the full SHA 584f779View commit details -
debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js
PR-URL: nodejs#39024 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f5dd504 - Browse repository at this point
Copy the full SHA f5dd504View commit details -
debugger: rename internal library for clarity
When I moved these files from node-inspect to Node.js core, I put them in lib/internal/inspector. That was a mistake. They should be in lib/internal/debugger. PR-URL: nodejs#39080 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2e8360e - Browse repository at this point
Copy the full SHA 2e8360eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1211825 - Browse repository at this point
Copy the full SHA 1211825View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cd07e1 - Browse repository at this point
Copy the full SHA 9cd07e1View commit details