Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] lint rules for globals #39448

Closed
wants to merge 3 commits into from
Closed

[v14.x backport] lint rules for globals #39448

wants to merge 3 commits into from

Commits on Jul 19, 2021

  1. lib: add globalThis to primordials 

    PR-URL: nodejs#38211
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @aduh95
    aduh95 committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    bb94e59 View commit details
    Browse the repository at this point in the history

  2. lib: enforce using primordials.globalThis instead of global 

    PR-URL: nodejs#38230
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @aduh95
    aduh95 committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    3eb7008 View commit details
    Browse the repository at this point in the history

  3. lib: harden lint checks for globals 

    PR-URL: nodejs#38419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @aduh95
    aduh95 committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    cacbccb View commit details
    Browse the repository at this point in the history