Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V12.x icu 69 support. #39451

Closed
wants to merge 2 commits into from

Commits on Jul 23, 2021

  1. deps: V8: cherry-pick 035c305ce776

    Original commit message:
    
        [Intl] call new ListFormatter::createInstance
    
        The one we currently using is now marked as internal and to be removed
        for 68. Migrating to the style which already avaiable in ICU 67-1.
    
        Bug: v8:11031
        Change-Id: I668382a2e1b8602ddca02bf231c5008a6c92bf2d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477751
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Frank Tang <ftang@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#70638}
    
    Refs: v8/v8@035c305
    
    PR-URL: nodejs#38497
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    af1a3fd View commit details
    Browse the repository at this point in the history
  2. deps: restore minimum ICU version to 65

    This modifies 40df0dc so that the changes it applies are only used
    if ICU 67 or greater is used, and restores the previous code path for
    versions of ICU below 67.
    
    The minimum ICU version was bumped to 67 in Node.js 14.6.0 by
    nodejs#34356 but the referenced V8
    commit[1] isn't on `v14.x-staging` and appears to have been reverted
    on V8 8.4[2] so this PR also restores the minimum ICU version to 65.
    
    [1] v8/v8@611e412
    [2] v8/v8@eeccede
    
    PR-URL: nodejs#39068
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    7d8c7a4 View commit details
    Browse the repository at this point in the history