v14.17.4 proposal

.eslintrc.js

@@ -25,10 +25,7 @@ Module._findPath = (request, paths, isMain) => {
   if (!r && hacks.includes(request)) {
     try {
       return require.resolve(`./tools/node_modules/${request}`);
-    // Keep the variable in place to ensure that ESLint started by older Node.js
-    // versions work as expected.
-    // eslint-disable-next-line no-unused-vars
-    } catch (e) {
+    } catch {
       return require.resolve(
         `./tools/node_modules/eslint/node_modules/${request}`);
     }
@@ -79,6 +76,29 @@ module.exports = {
         'doc/api/packages.md/*.js',
       ],
       parserOptions: { sourceType: 'module' },
+      rules: { 'no-restricted-globals': [
+        'error',
+        {
+          name: '__filename',
+          message: 'Use import.meta.url instead',
+        },
+        {
+          name: '__dirname',
+          message: 'Not available in ESM',
+        },
+        {
+          name: 'exports',
+          message: 'Not available in ESM',
+        },
+        {
+          name: 'module',
+          message: 'Not available in ESM',
+        },
+        {
+          name: 'require',
+          message: 'Use import instead',
+        },
+      ] },
     },
   ],
   rules: {

.github/SUPPORT.md

@@ -16,7 +16,7 @@ resources:
 
 * [Questions tagged 'node.js' on Stack Overflow](https://stackoverflow.com/questions/tagged/node.js)
 * [#nodejs](https://openjs-foundation.slack.com/archives/CK9Q4MB53) channel on the OpenJS Foundation Slack ([join here](https://slack-invite.openjsf.org/))
-* [#node.js channel on chat.freenode.net](https://webchat.freenode.net?channels=node.js&uio=d4)
+* [#node.js channel on libera.chat](https://web.libera.chat?channels=node.js&uio=d4)
 * [Node.js Slack Community](https://node-js.slack.com/)
   * To register: [nodeslackers.com](https://www.nodeslackers.com/)
 

.github/label-pr-config.yml

@@ -11,31 +11,31 @@ subSystemLabels:
   /^src\/udp_/: c++, dgram
   /^src\/(?:fs_|node_file|node_stat_watcher)/: c++, fs
   /^src\/node_http_parser/: c++, http_parser
-  /^src\/node_i18n/: c++, intl
+  /^src\/node_i18n/: c++, i18n-api
   /^src\/uv\./: c++, libuv
   /^src\/(?:connect(?:ion)?|pipe|tcp)_/: c++, net
   /^src\/node_os/: c++, os
   /^src\/(?:node_main|signal_)/: c++, process
   /^src\/timer_/: c++, timers
   /^src\/(?:CNNICHashWhitelist|node_root_certs|tls_)/: c++, tls
   /^src\/tty_/: c++, tty
-  /^src\/node_url/: c++, url-whatwg
+  /^src\/node_url/: c++, whatwg-url
   /^src\/node_util/: c++, util
-  /^src\/(?:node_v8|v8abbr)/: c++, V8 Engine
+  /^src\/(?:node_v8|v8abbr)/: c++, v8 engine
   /^src\/node_contextify/: c++, vm
   /^src\/.*win32.*/: c++, windows
   /^src\/node_zlib/: c++, zlib
   /^src\/tracing/: c++, tracing
-  /^src\/node_api/: c++, n-api
-  /^src\/node_http2/: c++, http2, dont-land-on-v6.x
+  /^src\/node_api/: c++, node-api
+  /^src\/node_http2/: c++, http2
   /^src\/node_report/: c++, report
   /^src\/node_wasi/: c++, wasi
   /^src\/node_worker/: c++, worker
   /^src\/quic\/*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x
   /^src\/node_bob*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x
 
   # don't label python files as c++
-  /^src\/.+\.py$/: lib / src, needs-ci
+  /^src\/.+\.py$/: python, needs-ci
 
   # properly label changes to v8 inspector integration-related files
   /^src\/inspector_/: c++, inspector, needs-ci
@@ -50,23 +50,24 @@ subSystemLabels:
   /^\w+\.md$/: doc
   # different variants of *Makefile and build files
   /^(tools\/)?(Makefile|BSDmakefile|create_android_makefiles|\.travis\.yml)$/: build, needs-ci
-  /^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, needs-ci
+  /^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci
   /^vcbuild\.bat$/: build, windows, needs-ci
   /^(android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci
   # more specific tools
-  /^tools\/gyp/: tools, build, needs-ci
+  /^tools\/gyp/: tools, build, gyp, needs-ci
   /^tools\/doc\//: tools, doc
-  /^tools\/icu\//: tools, intl, needs-ci
+  /^tools\/icu\//: tools, i18n-api, icu, needs-ci
   /^tools\/(?:osx-pkg\.pmdoc|pkgsrc)\//: tools, macos, install
   /^tools\/(?:(?:mac)?osx-)/: tools, macos
   /^tools\/test-npm/: tools, test, npm
   /^tools\/test/: tools, test
   /^tools\/(?:certdata|mkssldef|mk-ca-bundle)/: tools, openssl, tls
   /^tools\/msvs\//: tools, windows, install, needs-ci
   /^tools\/[^/]+\.bat$/: tools, windows, needs-ci
-  /^tools\/make-v8/: tools, V8 Engine, needs-ci
-  /^tools\/(code_cache|snapshot|v8_gypfiles)/: needs-ci,
-  /^tools\/build-addons.js/: needs-ci,
+  /^tools\/make-v8/: tools, v8 engine, needs-ci
+  /^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
+  /^tools\/(code_cache|snapshot)/: needs-ci
+  /^tools\/build-addons.js/: needs-ci
   # all other tool changes should be marked as such
   /^tools\//: tools
   /^\.eslint|\.remark|\.editorconfig/: tools
@@ -75,11 +76,12 @@ subSystemLabels:
   # libuv needs an explicit mapping, as the ordinary /deps/ mapping below would
   # end up as libuv changes labeled with "uv" (which is a non-existing label)
   /^deps\/uv\//: libuv
-  /^deps\/v8\/tools\/gen-postmortem-metadata\.py/: V8 Engine, post-mortem
-  /^deps\/v8\//: V8 Engine
+  /^deps\/v8\/tools\/gen-postmortem-metadata\.py/: v8 engine, python, post-mortem
+  /^deps\/v8\//: v8 engine
   /^deps\/uvwasi\//: wasi
-  /^deps\/nghttp2\/nghttp2\.gyp/: build, http2, dont-land-on-v6.x
-  /^deps\/nghttp2\//: http2, dont-land-on-v6.x
+  /^deps\/npm\//: npm, fast-track
+  /^deps\/nghttp2\/nghttp2\.gyp/: build, http2
+  /^deps\/nghttp2\//: http2
   /^deps\/ngtcp2\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
   /^deps\/nghttp3\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
   /^deps\/([^/]+)/: $1
@@ -94,10 +96,10 @@ subSystemLabels:
   /^lib\/\w+\/v8_prof_/: tools
   /^lib\/\w+\/socket_list/: net
   /^lib\/\w+\/streams$/: stream
-  /^lib\/.*http2/: http2, dont-land-on-v6.x
+  /^lib\/.*http2/: http2
   /^lib\/worker_threads.js$/: worker
-  /^lib\/internal\/url\.js$/: url-whatwg
-  /^lib\/internal\/modules\/esm/: ES Modules
+  /^lib\/internal\/url\.js$/: whatwg-url
+  /^lib\/internal\/modules\/esm/: esm
   /^lib\/internal\/quic\/*/: quic, dont-land-on-v14.x, dont-land-on-v12.x
 
   # All other lib/ files map directly
@@ -114,24 +116,22 @@ exlusiveLabels:
   /^test\/pseudo-tty\//: test, tty
   /^test\/inspector\//: test, inspector
   /^test\/cctest\/test_inspector/: test, inspector
-  /^test\/cctest\/test_url/: test, url-whatwg
-  /^test\/addons-napi\//: test, n-api
+  /^test\/cctest\/test_url/: test, whatwg-url
+  /^test\/addons-napi\//: test, node-api
   /^test\/async-hooks\//: test, async_hooks
   /^test\/report\//: test, report
-  /^test\/fixtures\/es-module/: test, ES Modules
-  /^test\/es-module\//: test, ES Modules
+  /^test\/fixtures\/es-module/: test, esm
+  /^test\/es-module\//: test, esm
 
   /^test\//: test
 
     # specific map for webcrypto.md as it should be labeled 'crypto'
   /^doc\/api\/webcrypto.md$/: doc, crypto
     # specific map for modules.md as it should be labeled 'module' not 'modules'
   /^doc\/api\/modules.md$/: doc, module
-    # specific map for esm.md as it should be labeled 'ES Modules' not 'esm'
-  /^doc\/api\/esm.md$/: doc, ES Modules
-    # n-api is treated separately since it is not a JS core module but is still
+    # node-api is treated separately since it is not a JS core module but is still
     # considered a subsystem of sorts
-  /^doc\/api\/n-api.md$/: doc, n-api
+  /^doc\/api\/n-api.md$/: doc, node-api
     # quic
   /^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x, dont-land-on-v12.x
     # add worker label to PRs that affect doc/api/worker_threads.md
@@ -140,12 +140,13 @@ exlusiveLabels:
   /^doc\/api\/(\w+)\.md$/: doc, $1
     # add deprecations label to PRs that affect doc/api/deprecations.md
   /^doc\/api\/deprecations.md$/: doc, deprecations
+  /^doc\/changelogs\//: release
 
   /^doc\//: doc
 
     # more specific benchmarks
   /^benchmark\/buffers\//: benchmark, buffer
-  /^benchmark\/(?:arrays|es)\//: benchmark, V8 Engine
+  /^benchmark\/(?:arrays|es)\//: benchmark, v8 engine
   /^benchmark\/_http/: benchmark, http
   /^benchmark\/(?:misc|fixtures)\//: benchmark
   /^benchmark\/streams\//: benchmark, stream

.github/workflows/auto-start-ci.yml

@@ -21,7 +21,7 @@ jobs:
 
       # Install dependencies
       - name: Install Node.js
-        uses: actions/setup-node@v2-beta
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Install node-core-utils

.github/workflows/commit-queue.yml

@@ -35,7 +35,7 @@ jobs:
 
       # Install dependencies
       - name: Install Node.js
-        uses: actions/setup-node@v2-beta
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Install node-core-utils
@@ -45,6 +45,7 @@ jobs:
         run: |
           echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV
           echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
+          echo "DEFAULT_BRANCH=${GITHUB_REF#refs/heads/}" >> $GITHUB_ENV
 
       - name: Get Pull Requests
         uses: octokit/graphql-action@v2.x
@@ -63,19 +64,19 @@ jobs:
           owner: ${{ env.OWNER }}
           repo: ${{ env.REPOSITORY }}
           # Commit queue is only enabled for the default branch on the repository
-          base_ref: ${{ github.repository.default_branch }}
+          base_ref: ${{ env.DEFAULT_BRANCH }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Configure node-core-utils
         run: |
-          ncu-config set branch ${{ github.repository.default_branch }}
+          ncu-config set branch ${DEFAULT_BRANCH}
           ncu-config set upstream origin
           ncu-config set username "${{ secrets.GH_USER_NAME }}"
           ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
           ncu-config set jenkins_token "${{ secrets.JENKINS_TOKEN }}"
-          ncu-config set repo "${{ env.REPOSITORY }}"
-          ncu-config set owner "${{ env.OWNER }}"
+          ncu-config set repo "${REPOSITORY}"
+          ncu-config set owner "${OWNER}"
 
       - name: Start the commit queue
-        run: ./tools/actions/commit-queue.sh ${{ env.OWNER }} ${{ env.REPOSITORY }} ${{ secrets.GITHUB_TOKEN }} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        run: ./tools/actions/commit-queue.sh ${OWNER} ${REPOSITORY} ${{ secrets.GITHUB_TOKEN }} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')

.github/workflows/daily.yml

@@ -0,0 +1,28 @@
+name: Node.js daily job
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: "0 0 * * *"
+
+env:
+  NODE_VERSION: 14.x
+
+jobs:
+  build-lto:
+    runs-on: ubuntu-latest
+    # not working on gcc-8 and gcc-9 see https://github.com/nodejs/node/issues/38570
+    container: gcc:11
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build lto
+        run: |
+          apt-get update && apt-get install ninja-build python-is-python3 -y
+          ./configure --enable-lto --ninja
+          ninja -C out/Release

.github/workflows/linters.yml

@@ -19,7 +19,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Environment Information
@@ -43,7 +43,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Environment Information
@@ -57,7 +57,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Environment Information

.github/workflows/misc.yml

@@ -18,7 +18,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Environment Information

.gitignore

@@ -117,7 +117,7 @@ tools/*/*.i.tmp
 /build
 /coverage
 
-# === Rules for XCode artifacts ===
+# === Rules for Xcode artifacts ===
 *.xcodeproj
 *.xcworkspace
 *.pbxproj

BUILDING.md

@@ -238,7 +238,7 @@ test with Python 3.
 * GNU Make 3.81 or newer
 * Python (see note above)
   * Python 2.7
-  * Python 3.5, 3.6, 3.7, and 3.8
+  * Python 3.5, 3.6, 3.7, or 3.8
 
 Installation via Linux package manager can be achieved with:
 
@@ -255,7 +255,7 @@ FreeBSD and OpenBSD users may also need to install `libexecinfo`.
 * Xcode Command Line Tools >= 10 for macOS
 * Python (see note above)
   * Python 2.7
-  * Python 3.5, 3.6, 3.7, and 3.8
+  * Python 3.5, 3.6, 3.7, or 3.8
 
 macOS users can install the `Xcode Command Line Tools` by running
 `xcode-select --install`. Alternatively, if you already have the full Xcode

CHANGELOG.md

@@ -30,7 +30,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V14.md#14.17.3">14.17.3</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V14.md#14.17.4">14.17.4</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V14.md#14.17.3">14.17.3</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.17.2">14.17.2</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.17.1">14.17.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.17.0">14.17.0</a><br/>

LICENSE

@@ -1333,29 +1333,6 @@ The externally maintained libraries used by Node.js are:
     WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
   """
 
-- node-inspect, located at deps/node-inspect, is licensed as follows:
-  """
-    Copyright Node.js contributors. All rights reserved.
-
-    Permission is hereby granted, free of charge, to any person obtaining a copy
-    of this software and associated documentation files (the "Software"), to
-    deal in the Software without restriction, including without limitation the
-    rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
-    sell copies of the Software, and to permit persons to whom the Software is
-    furnished to do so, subject to the following conditions:
-
-    The above copyright notice and this permission notice shall be included in
-    all copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-    FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
-    IN THE SOFTWARE.
-  """
-
 - large_pages, located at src/large_pages, is licensed as follows:
   """
      Copyright (C) 2018 Intel Corporation