stream: call done() in consistent fashion #39475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All three `destroy()` functions defined in adapter.js contain a `done()` function that takes no arguments. In one instance, however, an argument is nonetheless passed. Remove it for consistency.
jasnell
approved these changes
Jul 20, 2021
github-actions
bot
removed
the
request-ci
tniessen
approved these changes
Jul 21, 2021
evanlucas
approved these changes
Jul 22, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in f6b2893...44ee6c2 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
All three `destroy()` functions defined in adapter.js contain a `done()` function that takes no arguments. In one instance, however, an argument is nonetheless passed. Remove it for consistency. PR-URL: #39475 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com>
|
Depends on #39134 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All three
destroy()functions defined in adapter.js contain adone()function that takes no arguments. In one instance, however, an argument
is nonetheless passed. Remove it for consistency.