Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] http2: patch double-free error due to handling of rst_stream #39527

Closed
wants to merge 1 commit into from
Closed

[v12.x] http2: patch double-free error due to handling of rst_stream #39527

wants to merge 1 commit into from

Conversation

kumarak
Copy link
Contributor

@kumarak kumarak commented Jul 26, 2021

The PR patches the double-free error due to handling of
RST_STREAM frame with cancel code.

The previous PR(#39423) causes build failure with
v12.x-staging branch since the interfaces to check the
session flags changes. The changes backport APIs to
check the status flag of Http2Session as well.

Ref: #39423
Fixes: #38964

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39273/

@richardlau richardlau changed the title http2: patch double-free error due to handling of rst_stream in v12.x-staging [v12.x] http2: patch double-free error due to handling of rst_stream Jul 26, 2021
@richardlau
Copy link
Member

cc @nodejs/http2
I'll add a fast track label so we can get this into tomorrow's 12.22.4 release (#39500) if it's acceptable and passes CI.

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 26, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39275/

mcollina
mcollina approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and +1 to fast track

@richardlau richardlau force-pushed the kumarak/v12.x-stagging-build-error branch from f80771d to ba2ac7b Compare July 26, 2021 16:40
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39282/

@richardlau
Copy link
Member

Rebased as v12.x-staging was force-pushed.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39285/

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. v12.x labels Jul 26, 2021
richardlau pushed a commit that referenced this pull request Jul 27, 2021
@kumarak @richardlau
http2: on receiving rst_stream with cancel code add it to pending list
e47d2d2 
PR-URL: #39423
Backport-PR-URL: #39527
Fixes: #38964
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 27, 2021
@kumarak @richardlau
http2: on receiving rst_stream with cancel code add it to pending list
b263f25 
PR-URL: #39423
Backport-PR-URL: #39527
Fixes: #38964
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@richardlau
Copy link
Member

Landed in e47d2d2.

@richardlau richardlau closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kumarak @nodejs-github-bot @richardlau @mcollina @BethGriggs